10217 source name harvesting client #11217
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will help admin to customize their harvesting clients name in metadata source facet.
A new field called
sourceName
, a nullable TEXT, has been added.If set, it will overload the nickName in metadata source facet while indexing harvested dataset.
This will allow to have many harvesting client to be under the same
sourceName
if wished.Please have in mind that displaying nickName or
sourceName
requires to activate the feature flagindex-harvested-metadata-source
.This PR contains some refactoring and update on guide documentation.
Which issue(s) this PR closes:
Special notes for your reviewer:
I tested this code from user interface (Dashboard > create and edit havesting client popup) .
I tested this code from API also.
I was not able to test the HarvestingClientsIT in localhost.
My samples for testing :
Does this PR introduce a user interface change?:
The new field is visible in both creation and edition harvesting client popup :
Examples of harvesting result in metadata source :
Please note that both progedo and IRD are merged under "RDG Partners" in metadata source and CIRAD is displayed under CIRAD because the
sourceName
is not set.Is there a release notes update needed for this change?
Yes