-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup ci #4
Merged
Merged
Setup ci #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow for the purposes of deploy
This reverts commit f1a05c0.
Closed
4 tasks
jackbdoughty
previously approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me but couple things that I noticed:
- Not sure if its been changed since but the Keeper username to PyPi isn't the same as the email address so needs updating
- Noticed that in the acceptance criteria that that 'As this repo may be used by other groups in future (e.g. mantid), run the above checks in GH actions on most recent 3 python versions (following SPEC00 recommendation)' from what I understand this supports 3.10 and 3.11 not 3.12 but this is waiting on another ticket to be merged before possible. Worth keeping an eye on this
- Regarding the readme instructing how to create a release, it took me a couple extra steps as I had to find where/how to get the release approved in GH so maybe worth making it slightly clearer in the instructions :)
jackbdoughty
previously approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
jackbdoughty
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1