Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ci #4

Merged
merged 29 commits into from
Aug 2, 2024
Merged

Setup ci #4

merged 29 commits into from
Aug 2, 2024

Conversation

LowriJenkins
Copy link
Contributor

@LowriJenkins LowriJenkins commented Jul 23, 2024

#1

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 23, 2024
@LowriJenkins LowriJenkins mentioned this pull request Aug 1, 2024
4 tasks
@LowriJenkins LowriJenkins linked an issue Aug 1, 2024 that may be closed by this pull request
4 tasks
jackbdoughty
jackbdoughty previously approved these changes Aug 2, 2024
Copy link
Contributor

@jackbdoughty jackbdoughty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me but couple things that I noticed:

  • Not sure if its been changed since but the Keeper username to PyPi isn't the same as the email address so needs updating
  • Noticed that in the acceptance criteria that that 'As this repo may be used by other groups in future (e.g. mantid), run the above checks in GH actions on most recent 3 python versions (following SPEC00 recommendation)' from what I understand this supports 3.10 and 3.11 not 3.12 but this is waiting on another ticket to be merged before possible. Worth keeping an eye on this
  • Regarding the readme instructing how to create a release, it took me a couple extra steps as I had to find where/how to get the release approved in GH so maybe worth making it slightly clearer in the instructions :)

jackbdoughty
jackbdoughty previously approved these changes Aug 2, 2024
Copy link
Contributor

@jackbdoughty jackbdoughty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@jackbdoughty jackbdoughty merged commit ce4250b into main Aug 2, 2024
9 checks passed
@jackbdoughty jackbdoughty deleted the Setup_CI branch August 2, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up CI
3 participants