Skip to content

Commit

Permalink
Update CI
Browse files Browse the repository at this point in the history
  • Loading branch information
yasasghari committed Feb 9, 2024
1 parent 1f32c3a commit 396030d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,18 @@ jobs:
with:
name: test-report
path: |
jacoco-test.xml
target/site/jacoco/*
- name: static analysis
run: mvn spotbugs:check

- name: linting
run: mvn checkstyle:check

- name: CI passing merge to develop
if: success()
run: |
git fetch origin
git checkout develop
git merge --no-ff ${{ github.ref }}
git push origin develop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.stereotype.Controller;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
Expand Down Expand Up @@ -78,7 +79,7 @@ public ResponseEntity<Object> registration(@RequestBody PersonDTO personDTO) {
}
// User is saved to the database if the validation process is passed with no errors.
personService.saveApplicant(personDTO);
return new ResponseEntity<>(null, HttpStatus.OK);
return new ResponseEntity<>(new LinkedMultiValueMap<>(), HttpStatus.OK);
} catch (Exception e) {
return new ResponseEntity<>(new ErrorDTO("INVALID_OPERATION"), HttpStatus.BAD_REQUEST);
}
Expand Down

0 comments on commit 396030d

Please sign in to comment.