Skip to content

Fix: Module not loaded exception #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

LordHepipud
Copy link
Collaborator

Fixes an exception, telling the user a module is not loaded or installed, while the check itself returned a false value.

However, this check in general is useless and should be removed, as we can only check for components being loaded already, making it impossible to verify that a command is not available and loading the corresponding module, as we are unable to detect which module belongs to the command.

Therefor the entire test for this just causes CPU overhead and loading time for nothing.

Fixes #377

@cla-bot cla-bot bot added the cla/signed label Oct 27, 2021
@LordHepipud LordHepipud self-assigned this Oct 27, 2021
@LordHepipud LordHepipud added the Bug There is an issue present label Oct 27, 2021
@LordHepipud LordHepipud added this to the v1.7.0 milestone Oct 27, 2021
@LordHepipud LordHepipud merged commit 22b493b into master Oct 27, 2021
@LordHepipud LordHepipud deleted the fix/removes_module_loaded_testing branch October 27, 2021 09:04
@LordHepipud LordHepipud linked an issue Oct 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug There is an issue present cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception "Module not loaded" after Upgrade to 1.6.1 High CPU usage
1 participant