Skip to content

Fix: GC collection on every REST call #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

LordHepipud
Copy link
Collaborator

Fixes GC collection with Optimize-IcingaForWindowsMemory for every incoming REST connection call

Fixes #491

@cla-bot cla-bot bot added the cla/signed label Mar 17, 2022
@LordHepipud LordHepipud added this to the v1.9.0 milestone Mar 17, 2022
@LordHepipud LordHepipud added the Bug There is an issue present label Mar 17, 2022
@LordHepipud LordHepipud self-assigned this Mar 17, 2022
@haxtibal
Copy link
Contributor

Thanks for the quick response!

I've tested with an almost identical change yesterday, it notably reduced load.

You could go a bit further

And even further:

  • also reduce Optimize-IcingaForWindowsMemory calls from REST API worker threads

@LordHepipud LordHepipud force-pushed the fix/gc_collection_for_every_rest_connection branch 6 times, most recently from cf914d5 to f170305 Compare March 21, 2022 10:52
@LordHepipud LordHepipud force-pushed the fix/gc_collection_for_every_rest_connection branch from f170305 to 9a2e793 Compare April 6, 2022 11:59
@LordHepipud LordHepipud merged commit 89f4ac7 into master Apr 27, 2022
@LordHepipud LordHepipud deleted the fix/gc_collection_for_every_rest_connection branch April 27, 2022 06:52
@LordHepipud LordHepipud linked an issue May 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug There is an issue present cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize-IcingaForWindowsMemory causes high load High CPU usage
2 participants