Use new BaseObjectHeader class to create detail view header #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
changed the title
sukhwinder33445
force-pushed
the
create-detail-view-header-with-object-header-class
branch
7 times, most recently
from
b5c9062 to
3382816
Compare
sukhwinder33445
force-pushed
the
create-detail-view-header-with-object-header-class
branch
from
3382816 to
9c4b4de
Compare
sukhwinder33445
force-pushed
the
create-detail-view-header-with-object-header-class
branch
from
9c4b4de to
47f5a74
Compare
sukhwinder33445
force-pushed
the
create-detail-view-header-with-object-header-class
branch
2 times, most recently
from
6ebc500 to
7a39522
Compare
- Adjust RedundancyHeader class - Use this class to create object header for host and service - Remove previous implementation - Add required changes to `object-header.less` - StateList: Remove now unused NoSubjectLink
- Introduce trait CommentHeaderUtils
- Introduce trait DowntimeHeaderUtils
- Introduce EventHeaderUtils
sukhwinder33445
force-pushed
the
create-detail-view-header-with-object-header-class
branch
from
7a39522 to
045ed2c
Compare
nilmerg
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Haven't looked at everything yet, CSS not at all even.
Though, I'm already quite puzzled anyway. My expectation, and I told you this many times, was that nothing (or only with good reasoning) must change in the UI. As can be seen on the screenshots in my comments, this isn't the case.
| ->setDetailActionsDisabled() | ||
| ->setCaptionDisabled() | ||
| ->setNoSubjectLink()); | ||
| $this->addControl(new CommentHeader($this->comment)); |
| { | ||
| $detail = new DowntimeDetail($this->downtime); | ||
| $this->addControl(new DowntimeHeader($this->downtime)); |
| ->setCaptionDisabled() | ||
| ->setNoSubjectLink() | ||
| ->setDetailActionsDisabled()); | ||
| $this->addControl(new EventHeader($this->event)); |
| $this->addContent(Html::tag('h2', null, t('Hosts'))); | ||
| } else { | ||
| $this->addControl(new HostgroupTableRow($hostgroup)); | ||
| $this->addControl(new HostgroupHeader($hostgroup)); |
| ->setViewMode('objectHeader') | ||
| ->setDetailActionsDisabled() | ||
| ->setNoSubjectLink()); | ||
| $this->addControl(new ServiceHeader($this->service)); |
| $this->addContent(Html::tag('h2', null, t('Services'))); | ||
| } else { | ||
| $this->addControl(new ServicegroupTableRow($servicegroup)); | ||
| $this->addControl(new ServicegroupHeader($servicegroup)); |
| @@ -40,7 +40,7 @@ public function init() | |||
|
|
|||
| public function indexAction() | |||
| { | |||
| $this->addControl(new UserTableRow($this->user)); | |||
| $this->addControl(new UserHeader($this->user)); | |||
| @@ -40,7 +40,7 @@ public function init() | |||
|
|
|||
| public function indexAction() | |||
| { | |||
| $this->addControl(new UsergroupTableRow($this->usergroup)); | |||
| $this->addControl(new UsergroupHeader($this->usergroup)); | |||
| ->setNoSubjectLink() | ||
| ->setObjectLinkDisabled() | ||
| ->setDetailActionsDisabled(); | ||
| $comment = new CommentHeader($comment, false, true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.