VolatileStateResults: Fetch individual redis results for the actual current item #1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent item Previously, only the second and other subsequent item was updated with redis results. Not sure why this wasn't discovered until recently, as the issue was already part of the initial fix meant for a very similar issue, affecting *all* items. Hell, maybe because my initial analysis this time also led me into the wrong direction, so when reviewing this, proper testing and result verification is key! fixes #1318
nilmerg
added
bug
BastianLedererIcinga
approved these changes
Jan 21, 2026
Contributor
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
I've tested it on queries for specific hosts and services that haven't had a state change in several weeks, which is how I reproduced the bug previously.
The exported state-output was always up to date with the one shown in the UI, even when exporting right after observing a changed output.
When exporting all Hosts/Services ordered by last_state_change in ascending order, the first element was also up to date.
I also checked some of the subsequent elements and the last element in the larger queries, their output was also up to date.
nilmerg
deleted the
fix/first-result-of-host-and-service-exports-has-outdated-data-1318
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the second and other subsequent item was updated with redis results. Not sure why this wasn't discovered until recently, as the issue was already part of the initial fix meant for a very similar issue, affecting all items. Hell, maybe because my initial analysis this time also led me into the wrong direction, so when reviewing this, proper testing and result verification is key!
fixes #1318