Ipl forward compatibility#1340
Open
BastianLedererIcinga wants to merge 10 commits intosupport-php-8.4/8.5from
Open
Ipl forward compatibility#1340BastianLedererIcinga wants to merge 10 commits intosupport-php-8.4/8.5from
BastianLedererIcinga wants to merge 10 commits intosupport-php-8.4/8.5from
Conversation
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
0a29944 to
622bed8
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
3 times, most recently
from
cd3dd85 to
d8a9fdb
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
d8a9fdb to
cb75027
Compare
sukhwinder33445
previously approved these changes
Mar 6, 2026
BastianLedererIcinga
force-pushed
the
modernize-code
branch
3 times, most recently
from
1981131 to
b38a396
Compare
The constant is deprecated since php-8.5 but the replacement `Pdo\Mysql::ATTR_INIT_COMMAND` is only available since php-8.4
Passing `null` as `$key` to `array_key_exists()` or using it as an array key is deprecated since php-8.5
Errors that were no longer reported have been removed, keeping them in the baseline could hide future errors.
Since PHP 7.x is no longer supported the 7.x baseline is removed and it is no longer necessary have multiple baseline files.
Ensure the key `view` of the `ViewModeSwitcher` is not populated with `null` this previously caused PHP-8.5 deprecation warnigs in `ViewModeSwitcher::getViewMode()` because null was passed as `$key` to `array_key_exists()`
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
a42d158 to
05a46a9
Compare
Add return types to inheritos of `UnionModel` to ensure compatibility with ipl-orm.
Add return type `static` to implementations of `QueryAwareBehavior::setQuery()` to ensure forward-compatibility with ipl-orm.
Add return types to implementations of `RewriteFilterbehavior` to ensure forward-compatibility with ipl-orm
Add return types to ensure forward-compatibility with ipl-orm
Add retrun types to subclasses of `ResultSet` to make them forward-compatible with the ipl-orm
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
b38a396 to
5808d29
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
2 times, most recently
from
49d97b4 to
3caa773
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures forward compatibility with the modernized ipl-orm
Add types for:
UnionModelResultSetQueryAwareBehaviorRewriteFilterBehavior