Skip to content

Implement password policy with hook#5419

Open
JolienTrog wants to merge 71 commits into
mainfrom
password-policy
Open

Implement password policy with hook#5419
JolienTrog wants to merge 71 commits into
mainfrom
password-policy

Conversation

@JolienTrog

Copy link
Copy Markdown
Contributor

Ref #4401

@JolienTrog JolienTrog requested a review from Al2Klimov August 26, 2025 09:22
@cla-bot cla-bot Bot added the cla/signed label Aug 26, 2025
Al2Klimov

This comment was marked as resolved.

Al2Klimov

This comment was marked as resolved.

@JolienTrog JolienTrog requested a review from Al2Klimov August 26, 2025 15:21
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php Outdated
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php Outdated
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php Outdated
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php Outdated
@JolienTrog JolienTrog requested a review from Al2Klimov August 27, 2025 07:53
Comment thread library/Icinga/Authentication/PasswordValidator.php Outdated
Comment thread application/forms/Account/ChangePasswordForm.php Outdated
Comment thread application/forms/Config/GeneralConfigForm.php
Comment thread application/forms/Account/ChangePasswordForm.php Outdated
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php Outdated
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php Outdated
Comment thread application/forms/Config/User/UserForm.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Authentication/PasswordValidator.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Authentication/PasswordValidator.php Outdated
Comment thread library/Icinga/Authentication/PasswordValidator.php Outdated
Comment thread application/forms/Account/ChangePasswordForm.php Outdated
@JolienTrog JolienTrog requested a review from Al2Klimov August 28, 2025 08:35
Comment thread application/forms/Account/ChangePasswordForm.php Outdated
Comment thread library/Icinga/Application/Hook/PasswordPolicyHook.php
Comment thread library/Icinga/Application/Hook/PasswordPolicyHook.php Outdated
Comment thread library/Icinga/Application/Hook/PasswordPolicyHook.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread application/forms/Account/ChangePasswordForm.php
Comment thread application/forms/Config/User/UserForm.php
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Authentication/PasswordValidator.php Outdated
@JolienTrog JolienTrog requested a review from Al2Klimov August 28, 2025 11:05
Comment thread application/forms/Account/ChangePasswordForm.php Outdated
Comment thread application/forms/Account/ChangePasswordForm.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
@JolienTrog JolienTrog requested a review from Al2Klimov August 28, 2025 13:15
Comment thread library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/NonePasswordPolicy.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/NonePasswordPolicy.php
@JolienTrog JolienTrog requested a review from Al2Klimov August 28, 2025 14:05
Comment thread application/forms/Account/ChangePasswordForm.php Outdated
Comment thread application/forms/Config/User/UserForm.php Outdated
@JolienTrog JolienTrog requested a review from Al2Klimov August 28, 2025 15:26

@Al2Klimov Al2Klimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During setup, the wizard prompts me for a username and password "to configure your first administrative account". This should enforce the chosen password policy.

@JolienTrog JolienTrog force-pushed the password-policy branch 2 times, most recently from 97e07ad to 39bbc53 Compare September 2, 2025 10:24
Comment thread test/php/library/Icinga/Application/CommonPasswordPolicyTest.php Outdated
Comment thread test/php/library/Icinga/Application/CommonPasswordPolicyTest.php Outdated
Comment thread test/php/library/Icinga/Application/CommonPasswordPolicyTest.php Outdated
Comment thread test/php/library/Icinga/Application/CommonPasswordPolicyTest.php Outdated
Comment thread library/Icinga/Application/Hook/PasswordPolicyHook.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/CommonPasswordPolicy.php Outdated
Comment thread library/Icinga/Application/ProvidedHook/CommonPasswordPolicy.php Outdated
Comment thread application/forms/Config/General/PasswordPolicyConfigForm.php Outdated
Comment thread test/php/library/Icinga/Application/NoPasswordPolicyTest.php
Comment thread test/php/library/Icinga/Application/CommonPasswordPolicyTest.php Outdated
Comment thread test/php/library/Icinga/Application/CommonPasswordPolicyTest.php Outdated
@TheSyscall

Copy link
Copy Markdown
Contributor

Changed class loading to ask the hook by a canonical name instead of storing the class path and instantiating a class from that.

Since we now have the new callouts (Icinga/ipl-web#358) consider using them in the PasswordPolicyHelper instead of the custom callout.

Used callouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants