Conversation
52f1357 to
415ad2b
Compare
4bc935f to
422c34e
Compare
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
The return type of BaseFilter::setBaseFilter can be changed to static.
01fc4fa to
2030a2d
Compare
5c7ad36 to
0e8fbc5
Compare
6408fa8 to
d67ed2a
Compare
d67ed2a to
dd095bd
Compare
The base branch was changed.
|
Please rebase. |
0e8fbc5 to
20d500b
Compare
I assume you mean the |
sukhwinder33445
left a comment
There was a problem hiding this comment.
Everything else looks good to me.
Please ignore, we cannot add a return type to |
4831767 to
5ffb327
Compare
5ffb327 to
8a06264
Compare
sukhwinder33445
left a comment
There was a problem hiding this comment.
Looks good to me.
8a06264 to
77be55b
Compare
Add strict type declarations to properties, function/method signatures, where types are unambiguous and no inheritance is affected. Remove any now superfluous type checks. PHPDoc adjusted: nullable shorthand, union type ordering, compact format. Raise minimum PHP version to 8.0. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
Raise minimum PHP version to 8.2. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
This change requires adjustments to the following consumers:
ipl-html:
- src/Contract/FormElement.php
PHPDoc adjusted: nullable shorthand, union type ordering, compact format.
This change requires adjustments to the following consumers:
ipl-orm:
- src/Common/PropertiesWithDefaults.php
This change requires adjustments to the following consumers:
ipl-sql
- src/Cursor.php
- src/LimitOffset.php
PHPDoc adjusted: nullable shorthand, union type ordering, compact format.
This change requires adjustments to the following consumers:
ipl-i18n
- src/GettextTranslator.php
- src/NoopTranslator.php
PHPDoc adjusted: nullable shorthand, union type ordering, compact format.
77be55b to
903490d
Compare
Add PHP 8.2+ type declarations across codebase
This PR adds comprehensive type declarations to the entire codebase, enabling modern PHP type system features and improving static analysis capabilities. It also modernizes the codebase to require PHP 8.2 or later.
Changes
Type System Improvements
mixedwhere appropriate (e.g.,array<mixed>|bool|float|int|string→mixed)Code Refactoring
switch/casestatements to modernmatchexpressions inFilter::performMatch()selfreturn type withstaticfor better fluent interface supportInterface Updates
Filterable,Paginatable,PluginLoader,Translator)?stringtype hints for optional context parametersMinimum Version Requirement
composer.jsonto require PHP 8.2 or laterBreaking Changes
Requires PHP 8.2+ - Projects using PHP 7.x will need to upgrade
The following classes and interfaces have not been modernized because they have dependencies
(to many overrides)
(parameter
$eventstays without type to match the definition of the interfaceEvenement\EventEmitterInterface)(without return type to match the definition of the interface
ipl\Stdlib\Contract\Validator)