Skip to content

Introduce SuggestionElement#305

Merged
nilmerg merged 2 commits into
mainfrom
introduce-suggestion-element
Aug 12, 2025
Merged

Introduce SuggestionElement#305
nilmerg merged 2 commits into
mainfrom
introduce-suggestion-element

Conversation

@sukhwinder33445

@sukhwinder33445 sukhwinder33445 commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

@sukhwinder33445 sukhwinder33445 self-assigned this Jul 28, 2025
@cla-bot cla-bot Bot added the cla/signed label Jul 28, 2025
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch 6 times, most recently from d100fdd to a77556b Compare July 29, 2025 10:00

This comment was marked as resolved.

@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch 4 times, most recently from 5c5e2d0 to 031ae7c Compare July 29, 2025 10:30
Comment thread src/FormElement/SuggestionElement.php Outdated
Comment thread src/FormElement/SuggestionElement.php Outdated
Comment thread src/FormElement/SuggestionElement.php Outdated
Comment thread asset/css/suggestion-element.less
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch from 031ae7c to 99bac55 Compare August 1, 2025 08:23
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg August 1, 2025 10:54
Comment thread asset/css/suggestion-element.less Outdated
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch from 99bac55 to 8409889 Compare August 4, 2025 16:07
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg August 4, 2025 16:13
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch from 8409889 to a005895 Compare August 5, 2025 07:26
Comment thread asset/css/suggestion-element.less Outdated
Comment thread asset/css/suggestion-element.less Outdated
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch from a005895 to 89e8e04 Compare August 6, 2025 09:24
Comment thread asset/css/suggestion-element.less Outdated
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg August 6, 2025 09:36
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch 3 times, most recently from 31edc32 to 4e5ee50 Compare August 6, 2025 10:24

@nilmerg nilmerg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outline of the input should cover the search icon:

Image

Comment thread asset/css/suggestion-element.less Outdated
Comment thread asset/css/suggestion-element.less Outdated
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-suggestion-element branch from 2d3da6a to ff14afd Compare August 11, 2025 08:40
@nilmerg nilmerg added this to the v0.12.0 milestone Aug 12, 2025
@nilmerg nilmerg merged commit b8f56d2 into main Aug 12, 2025
11 checks passed
@nilmerg nilmerg deleted the introduce-suggestion-element branch August 12, 2025 10:29
nilmerg added a commit to Icinga/icinga-notifications-web that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants