Conversation
raviks789
force-pushed
the
use-sanitized-name-as-element-name
branch
from
August 14, 2025 14:23
6f590d8 to
77a6c32
Compare
nilmerg
requested changes
Aug 18, 2025
nilmerg
left a comment
nilmerg
left a comment
Member
There was a problem hiding this comment.
We've talked already about this in person. This should not solely rely on the sanitized element name. Or even not at all. Form element name validity is a different subject than ID attribute validity.
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref Icinga/ipl-html#149
Blocked by: Icinga/ipl-html#150