Skip to content

Parts update improvement - #408

Merged
nilmerg merged 2 commits into
mainfrom
parts-update-improvement
Sep 11, 2026
Merged

nilmerg merged 2 commits into
mainfrom
parts-update-improvement

Conversation

@nilmerg

@nilmerg nilmerg commented Sep 10, 2026

Copy link
Copy Markdown
Member

Adds only some minor fixes. I noticed a repeated pattern with usages of TermInput::prepareMultipartUpdate():

foreach ($termInput->prepareMultipartUpdate() as $update) {
    if (! is_array($update)) {
        $update = [$update];
    }

    $controller->addPart(...$update);
}

It can now be reduced to this:

foreach ($termInput->prepareMultipartUpdate() as $update) {
    $controller->addPart(...$update);
}

@Jan-Schuppik Jan-Schuppik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nilmerg
nilmerg merged commit 140d52d into main Sep 11, 2026
14 checks passed
@nilmerg
nilmerg deleted the parts-update-improvement branch September 11, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants