Skip to content

fix: JWS header typ according to RFC7519 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2022
Merged

fix: JWS header typ according to RFC7519 #127

merged 3 commits into from
Jun 22, 2022

Conversation

peppelinux
Copy link
Member

Closes #126

@peppelinux peppelinux requested review from rohe and jschlyter June 20, 2022 15:46
jschlyter
jschlyter requested changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we get test coverage as well so it won't happen again?

@peppelinux
Copy link
Member Author

  • added test
  • moved version up to v1.8.3

@jschlyter jschlyter merged commit 7951474 into main Jun 22, 2022
@jschlyter jschlyter deleted the jws-typ-typo branch June 22, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschlyter jschlyter jschlyter approved these changes

@rohe rohe Awaiting requested review from rohe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why JWS converts "typ" header claim name in "type"
2 participants
@peppelinux @jschlyter