Skip to content

Add python linting using flake8 #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Add python linting using flake8 #378

wants to merge 9 commits into from

Conversation

ashimaathri
Copy link
Contributor

@ashimaathri ashimaathri commented Oct 28, 2016

This helps keep the code consistent and provides an extra check for the code.
Some type of errors that it caught were:

  1. An error that was introduced in a previous PR Use importlib in place of backports.test.support #375 (src/saml2/s_utils.py:384:43: F821 undefined name 'sha')
  2. Usage of unicode and long which is not supported anymore in python3
  3. Helped identify unused imports

Improves code quality by 0.51% 😸 https://landscape.io/github/rohe/pysaml2/pulls/378
The 'new' issues reported by landscape are not new at all. I think after the refactor, it began detecting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant