Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prep_for_nego_auth: avoid double signing redirect requests #973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: prep_for_nego_auth: avoid double signing redirect requests #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/saml2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ def prepare_for_negotiated_authenticate(
# XXX ^through self.create_authn_request(...)
# XXX - sign_redirect will add the signature to the query params
# XXX ^through self.apply_binding(...)
sign_redirect = sign and binding == BINDING_HTTP_REDIRECT
sign_post = sign and not sign_redirect
sign_redirect = sign if binding == BINDING_HTTP_REDIRECT else False
sign_post = sign if binding != BINDING_HTTP_REDIRECT else False

reqid, request = self.create_authn_request(
destination=destination,
Expand Down