replace pyopenssl with cryptography #977
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
@c00kiemon5ter Is there anything you need or I could help you with to bring this forward? |
miettal
added a commit
to girasolenergy/pysaml2
that referenced
this pull request
Mar 13, 2025
This PR upgrade pyopenssl dependency. Current constraints is `<24.3.0`(up to 24.2.x). New constratints is `<24.4.0`(up to 24.3.x). This PR is for addressing security alert `GHSA-79v4-65xg-pq4g`. GHSA-79v4-65xg-pq4g // I guess this constratints is for pyopenssl->cryptography migration. IdentityPython#977 IdentityPython@735bfa5
|
Hi ! At work we use @prauscher branch in production on multiple backends since yesterday with [email protected] and [email protected] and it works like a charm. I hope this small datapoint will give more confidence to merge this PR :) |
| cert.set_issuer(cert.get_subject()) | ||
| cert.set_pubkey(k) | ||
| cert.sign(k, hash_alg) | ||
| now = datetime.datetime.now(datetime.UTC) |
There was a problem hiding this comment.
To be compatible with Python < 3.11 datetime.UTC needs to be change to datetime.timezone.utc.
| sign_key_str, password=passphrase) | ||
| req_cert = x509.load_pem_x509_csr(request_cert_str) | ||
|
|
||
| now = datetime.datetime.now(datetime.UTC) |
| cert_str = cert_str.encode("utf-8") | ||
| ca_cert = x509.load_pem_x509_certificate(signing_cert_str) | ||
| cert = x509.load_pem_x509_certificate(cert_str) | ||
| now = datetime.datetime.now(datetime.UTC) |
| valid_from = dateutil.parser.parse(cert.get_notBefore()) | ||
| valid_to = dateutil.parser.parse(cert.get_notAfter()) | ||
| active = not cert.has_expired() and valid_from <= now < valid_to | ||
| now = datetime.datetime.now(datetime.UTC) |
|
I also merged @prauscher branch to our repo and, with my exception above, have seen no problems. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #879
Description
The feature or problem addressed by this PR
This PR replaces pyopenssl whose usage is discouraged by its own developers. This is especially current since pyopenssl was forced to a version before 24.3.0 in response to #975. This inturn forces older cryptography-versions, making automated vulnerability checkers go brr.
What your changes do and why you chose this solution
The replacement of pyopenssl is quite direct, so probably cryptography could be used to a larger extend, reducing own security functions. On the other hand, cryptography is currently quite fixed to client/server authentification, enforcing stricter regulations on Certificate extensions etc, which might not be suitable here.
I ran the test suite on my machine which looked good, however while pyopenssl usually accepts strings or bytes, cryptography is usually fixed to bytes, forcing encoding to its user, so there may be dragons.
This being my first PR here, I'd highly value feedback and be happy to assist.
Checklist