Conversation
Recent changes regressed the way windows are rotated using the bar bellow the front window. Window position "jumped" just after grabbing the bar. Now we use a much better approach, we compute relative rotations to the initial window position to reorient them. This way we always get the proper orientation even after recentering the view. Quaternion interpolation using SLERP is also used to smoothen the window movements providing a much more appealing experience. Fixes #1945
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in window rotation when using the move bar below the front window. The previous implementation caused window positions to "jump" when grabbing the bar. The new approach computes relative rotations from the initial window position and uses quaternion SLERP interpolation for smoother movements.
- Replaced ad-hoc pitch correction with proper relative rotation calculation
- Introduced SLERP interpolation to smooth window movements during rotation
- Simplified the rotation logic by removing the navigationBarToWindowTransform workaround
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javifernandez
approved these changes
Dec 10, 2025
Member
javifernandez
left a comment
javifernandez
left a comment
There was a problem hiding this comment.
Looks good and it fixes the issue.
Thanks !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes regressed the way windows are rotated using the bar bellow the front window. Window position "jumped" just after grabbing the bar. Now we use a much better approach, we compute relative rotations to the initial window position to reorient them. This way we always get the proper orientation even after recentering the view.
Quaternion interpolation using SLERP is also used to smoothen the window movements providing a much more appealing experience.
Fixes #1945