Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Tabs/BottomNav Routing Samples #1267

Merged
merged 19 commits into from
Jul 17, 2019
Merged

Adding Tabs/BottomNav Routing Samples #1267

merged 19 commits into from
Jul 17, 2019

Conversation

rmkrmk
Copy link
Contributor

@rmkrmk rmkrmk commented Jul 8, 2019

@rmkrmk rmkrmk requested a review from gedinakova July 8, 2019 13:17
gedinakova
gedinakova previously approved these changes Jul 9, 2019
View reviewed changes
@DiyanDimitrov DiyanDimitrov self-requested a review July 12, 2019 07:53
DiyanDimitrov
DiyanDimitrov previously approved these changes Jul 12, 2019
View reviewed changes
gedinakova
gedinakova requested changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@gedinakova gedinakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into the other samples for Tabs and BottomNav, it seems they are showing more real use scenarios - tabs with contacts or some information about an artist. I think we should reconsider the content presented in the routing samples.

@rmkrmk
Copy link
Contributor Author

rmkrmk commented Jul 16, 2019

The routing sample now has a new data source and different components are used.

gedinakova
gedinakova previously approved these changes Jul 16, 2019
View reviewed changes
@DiyanDimitrov DiyanDimitrov self-requested a review July 17, 2019 08:35
@DiyanDimitrov DiyanDimitrov merged commit e721aa7 into master Jul 17, 2019
@DiyanDimitrov DiyanDimitrov deleted the rkolev/tabsBottonNavTabsDefinitionMode branch July 17, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

@gedinakova gedinakova gedinakova left review comments

Assignees

@DiyanDimitrov DiyanDimitrov

Labels
bottom-nav status: verified tabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmkrmk @gedinakova @DiyanDimitrov