feat(stepper): test animations with other values

Author: ddaribo

projects/igniteui-angular/src/lib/stepper/stepper.component.spec.ts

@@ -48,6 +48,28 @@ const getStepperPositions = (): string[] => {
     return positions;
 };
 
+const testAnimationBehvior = (
+    val: any,
+    fix: ComponentFixture<IgxStepperSampleTestComponent>,
+    isHorAnimTypeInvalidTest: boolean
+): void => {
+    const stepper = fix.componentInstance.stepper;
+    stepper.steps[0].active = true;
+    fix.detectChanges();
+    const previousActiveStep = stepper.steps[0];
+    const activeChangeSpy = spyOn(previousActiveStep.activeChange, 'emit');
+    activeChangeSpy.calls.reset();
+    stepper.next();
+    fix.detectChanges();
+    tick(1000);
+    if (!isHorAnimTypeInvalidTest) {
+        expect(previousActiveStep.activeChange.emit).withContext(val).toHaveBeenCalledOnceWith(false);
+    } else {
+        expect(previousActiveStep.activeChange.emit).withContext(val).not.toHaveBeenCalled();
+    }
+    activeChangeSpy.calls.reset();
+};
+
 describe('Rendering Tests', () => {
     configureTestSuite();
     let fix: ComponentFixture<IgxStepperSampleTestComponent>;
@@ -205,7 +227,7 @@ describe('Rendering Tests', () => {
 
             const testValues = [null, undefined, [], {}, 'sampleString'];
 
-            for(const val of testValues){
+            for (const val of testValues) {
                 stepper.navigateTo(val as any);
                 fix.detectChanges();
                 expect(changingSpy).not.toHaveBeenCalled();
@@ -421,7 +443,7 @@ describe('Rendering Tests', () => {
             fix.detectChanges();
 
             let positions = getStepperPositions();
-            positions.forEach((pos: string) => {
+            positions.forEach((pos: IgxStepperTitlePosition) => {
                 stepper.horizontalTitlePosition = pos;
                 fix.detectChanges();
 
@@ -434,7 +456,7 @@ describe('Rendering Tests', () => {
             fix.detectChanges();
 
             positions = getStepperPositions();
-            positions.forEach((pos: string) => {
+            positions.forEach((pos: IgxStepperTitlePosition) => {
                 stepper.verticalTitlePosition = pos;
                 fix.detectChanges();
 
@@ -514,59 +536,57 @@ describe('Rendering Tests', () => {
             expect(stepper.nativeElement.children[1]).toHaveClass(STEPPER_HEADER);
         });
 
-        it('should allow modifying animationSettings that are used for transitioning between steps ', () => {
-            stepper.orientation = IgxStepperOrientation.Horizontal;
-            fix.detectChanges();
-
-            expect(stepper.animationDuration).toBe(fix.componentInstance.animationDuration);
-            fix.componentInstance.animationDuration = 1000;
-            fix.detectChanges();
-
-            expect(stepper.animationDuration).toBe(1000);
-
-            fix.componentInstance.animationDuration = null;
-            fix.detectChanges();
+        it('should allow modifying animationSettings that are used for transitioning between steps ', fakeAsync(() => {
+            const numericTestValues = [100, 1000];
 
-            expect(stepper.animationDuration).toBe((stepper as any)._defaultAnimationDuration);
+            for (const val of numericTestValues) {
+                fix.componentInstance.animationDuration = val as any;
+                testAnimationBehvior(val, fix, false);
+            }
 
-            fix.componentInstance.animationDuration = undefined;
-            fix.detectChanges();
+            const dummyTestValues = [-1, 'sampleString', [], {}];
 
-            expect(stepper.animationDuration).toBe((stepper as any)._defaultAnimationDuration);
+            for (const val of dummyTestValues) {
+                expect(() => {
+                    fix.componentInstance.animationDuration = val as any;
+                    testAnimationBehvior(val, fix, false);
+                }).toThrow();
+            }
 
-            expect(stepper.horizontalAnimationType).toBe(fix.componentInstance.horizontalAnimationType);
-            expect(stepper.horizontalAnimationType).toBe('slide');
+            const fallbackToDefaultValues = [0, null];
+            for (const val of fallbackToDefaultValues) {
+                fix.componentInstance.animationDuration = val as any;
+                fix.detectChanges();
+                expect(stepper.animationDuration).withContext('Set 0/null animation duration and verify default value')
+                    .toBe((stepper as any)._defaultAnimationDuration);
+                testAnimationBehvior(val, fix, false);
+            }
 
-            fix.componentInstance.horizontalAnimationType = 'fade';
+            fix.componentInstance.animationDuration = 300;
+            stepper.orientation = IgxStepperOrientation.Horizontal;
             fix.detectChanges();
 
-            expect(stepper.horizontalAnimationType).toBe(fix.componentInstance.horizontalAnimationType);
-            expect(stepper.horizontalAnimationType).toBe('fade');
-
-            fix.componentInstance.horizontalAnimationType = 'none';
-            fix.detectChanges();
+            const horAnimTypeValidValues = ['slide', 'fade', 'none'];
+            for (const val of horAnimTypeValidValues) {
+                fix.componentInstance.horizontalAnimationType = val as any;
+                testAnimationBehvior(val, fix, false);
+            }
 
-            expect(stepper.horizontalAnimationType).toBe(fix.componentInstance.horizontalAnimationType);
-            expect(stepper.horizontalAnimationType).toBe('none');
+            const horAnimTypeTestValues = ['sampleString', null, undefined, 0, [], {}];
+            for (const val of horAnimTypeTestValues) {
+                fix.componentInstance.horizontalAnimationType = val as any;
+                testAnimationBehvior(val, fix, true);
+            }
 
             stepper.orientation = IgxStepperOrientation.Vertical;
             fix.detectChanges();
 
-            expect(stepper.verticalAnimationType).toBe(fix.componentInstance.verticalAnimationType);
-            fix.componentInstance.verticalAnimationType = 'grow';
-
-            fix.componentInstance.verticalAnimationType = 'fade';
-            fix.detectChanges();
-
-            expect(stepper.verticalAnimationType).toBe(fix.componentInstance.verticalAnimationType);
-            expect(stepper.verticalAnimationType).toBe('fade');
-
-            fix.componentInstance.verticalAnimationType = 'none';
-            fix.detectChanges();
-
-            expect(stepper.verticalAnimationType).toBe(fix.componentInstance.verticalAnimationType);
-            expect(stepper.verticalAnimationType).toBe('none');
-        });
+            const vertAnimTypeTestValues = ['fade', 'grow', 'none', 'sampleString', null, undefined, 0, [], {}];
+            for (const val of vertAnimTypeTestValues) {
+                fix.componentInstance.verticalAnimationType = val as any;
+                testAnimationBehvior(val, fix, false);
+            }
+        }));
 
         it('should render dynamically added step and properly set the linear disabled steps with its addition', fakeAsync(() => {
             const stepsLength = stepper.steps.length;
@@ -670,14 +690,7 @@ describe('Rendering Tests', () => {
         it('should properly collapse the previously active step in horizontal orientation and animation type \'fade\'', fakeAsync(() => {
             stepper.orientation = IgxStepperOrientation.Horizontal;
             stepper.horizontalAnimationType = 'fade';
-            stepper.steps[0].active = true;
-            fix.detectChanges();
-
-            const previousActiveStep = stepper.steps[0];
-            spyOn(previousActiveStep.activeChange, 'emit');
-
-            stepper.next();
-            expect(previousActiveStep.activeChange.emit).toHaveBeenCalledOnceWith(false);
+            testAnimationBehvior('fade', fix, false);
         }));
     });
 
@@ -1011,7 +1024,7 @@ describe('Stepper service unit tests', () => {
 
         const testValues = [null, undefined, [], {}, 'sampleString'];
 
-        for(const val of testValues){
+        for (const val of testValues) {
             expect(() => {
                 stepperService.expand(val as any);
             }).toThrow();
@@ -1048,7 +1061,7 @@ describe('Stepper service unit tests', () => {
 
         const testValues = [null, undefined, [], {}, 'sampleString'];
 
-        for(const val of testValues){
+        for (const val of testValues) {
             expect(() => {
                 stepperService.expandThroughApi(val as any);
             }).toThrow();
@@ -1101,7 +1114,7 @@ describe('Stepper service unit tests', () => {
 
         const testValues = [null, undefined, [], {}, 'sampleString'];
 
-        for(const val of testValues){
+        for (const val of testValues) {
             expect(() => {
                 stepperService.collapse(val as any);
             }).toThrow();
@@ -1297,5 +1310,3 @@ export class IgxStepperSampleTestComponent {
     public displayHiddenStep = false;
 
 }
-
-