Skip to content

Commit 90f9868

Browse files
committed
chore(combo): simplify CHANGELOG entry, reuse private method
1 parent 27a0b5d commit 90f9868

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ All notable changes for each version of this project will be documented in this
9494
...
9595
handleSelection(event: IComboSelectionChangeEventArgs) {
9696
const count = event.newSelection.length;
97-
event.textValue = count > 0 ? `${count} friend${count > 1 ? 's' : ''} invited!` : `No friends invited :(`;
97+
event.textValue = count > 0 ? `${count} friend(s) invited!` : `No friends invited :(`;
9898
}
9999
...
100100
}

projects/igniteui-angular/src/lib/combo/combo.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,9 +1413,7 @@ export class IgxComboComponent extends DisplayDensityBase implements IgxComboBas
14131413
this.registerRemoteEntries(args.oldSelection, false);
14141414
}
14151415
} else {
1416-
value = this.displayKey !== null && this.displayKey !== undefined ?
1417-
this.convertKeysToItems(args.newSelection).map(entry => entry[this.displayKey]).join(', ') :
1418-
args.newSelection.join(', ');
1416+
value = this.concatTextValue(args.newSelection);
14191417
}
14201418
this._value = value;
14211419
this._onChangeCallback(args.newSelection);

0 commit comments

Comments
 (0)