chore(*): more code improvements #4647

Author: SAndreeva

projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts

@@ -54,7 +54,6 @@ import { KEYS, CancelableBrowserEventArgs } from '../core/utils';
 import { IgxDatePickerTemplateDirective, IgxDatePickerActionsDirective } from './date-picker.directives';
 import { IgxCalendarContainerComponent } from './calendar-container.component';
 import { InteractionMode } from '../core/enums';
-import { getViewportRect } from '../services/overlay/utilities';
 import { fadeIn, fadeOut } from '../animations/fade';
 import { DeprecateProperty } from '../core/deprecateDecorators';
 
@@ -540,6 +539,7 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
     public outlet: IgxOverlayOutletDirective | ElementRef;
 
     /**
+     * @deprecated Use 'onOpened' instead.
      *An event that is emitted when the `IgxDatePickerComponent` calendar is opened.
      *```typescript
      *public open(event){
@@ -561,6 +561,7 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
     public onOpened = new EventEmitter<IgxDatePickerComponent>();
 
     /**
+     * @deprecated Use 'onClosed' instead.
      *"An event that is emitted when the `IgxDatePickerComponent` is closed.
      *```typescript
      *public close(event){

projects/igniteui-angular/src/lib/date-picker/date-picker.directives.ts

@@ -1,4 +1,4 @@
-import { Directive, TemplateRef, Input } from '@angular/core';
+import { Directive, TemplateRef } from '@angular/core';
 
 @Directive({
     selector: '[igxDatePickerTemplate]'

projects/igniteui-angular/src/lib/time-picker/time-picker.common.ts

@@ -28,7 +28,7 @@ export interface IgxTimePickerBase {
     scrollHourIntoView(item: string): void;
     scrollMinuteIntoView(item: string): void;
     scrollAmPmIntoView(item: string): void;
-    hideOverlay(): void;
+    close(): void;
     parseMask(preserveAmPm?: boolean): string;
 }
 

projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

@@ -402,6 +402,7 @@ export class IgxTimePickerComponent implements
     public onValidationFailed = new EventEmitter<IgxTimePickerValidationFailedEventArgs>();
 
     /**
+     * @deprecated Use 'onOpened' instead.
      * Emitted when a timePicker is being opened.
      * ```html
      *@ViewChild("toast")
@@ -427,6 +428,7 @@ export class IgxTimePickerComponent implements
     public onOpened = new EventEmitter<IgxTimePickerComponent>();
 
     /**
+     * @deprecated Use 'onClosed' instead.
      * Emitted when a timePicker is being closed.
      */
     @DeprecateProperty(`'onClose' @Output property is deprecated. Use 'onClosed' instead.`)
@@ -1428,7 +1430,7 @@ export class IgxTimePickerComponent implements
     public okButtonClick(): boolean {
         const time = this._getSelectedTime();
         if (this._isValueValid(time)) {
-            this.hideOverlay();
+            this.close();
             this.value = time;
             return true;
         } else {
@@ -1455,7 +1457,7 @@ export class IgxTimePickerComponent implements
             this.displayValue = this._formatTime(this.value, this.format);
         }
 
-        this.hideOverlay();
+        this.close();
 
         this.selectedHour = this._prevSelectedHour;
         this.selectedMinute = this._prevSelectedMinute;
@@ -1511,10 +1513,10 @@ export class IgxTimePickerComponent implements
      * ```
      * ```typescript
      * @ViewChild('timePicker', { read: IgxTimePickerComponent }) picker: IgxTimePickerComponent;
-     * picker.hideOverlay();
+     * picker.close();
      * ```
      */
-    public hideOverlay(): void {
+    public close(): void {
         this.toggleRef.close();
     }
 
@@ -1549,7 +1551,7 @@ export class IgxTimePickerComponent implements
                 this.onValueChanged.emit(args);
             }
         } else {
-            this.hideOverlay();
+            this.close();
         }
     }
 

projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts

@@ -157,7 +157,7 @@ export class IgxItemListDirective {
         event.preventDefault();
 
         if (this.timePicker.mode === InteractionMode.DropDown) {
-            this.timePicker.hideOverlay();
+            this.timePicker.close();
             return;
         }
         this.timePicker.okButtonClick();

src/app/time-picker/time-picker.sample.ts

@@ -64,6 +64,6 @@ export class TimePickerSampleComponent implements AfterViewInit {
 
     public selectToday(picker: IgxTimePickerComponent) {
         picker.value = new Date(Date.now());
-        picker.hideOverlay();
+        picker.close();
     }
 }