Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More features in date picker #4647

Closed
Eralmidia opened this issue Apr 24, 2019 · 6 comments · Fixed by #5027
Closed

More features in date picker #4647

Eralmidia opened this issue Apr 24, 2019 · 6 comments · Fixed by #5027
Assignees
@StefanIvanov @bkulov @SAndreeva @SlavUI
Labels
📈 enhancement 🕐 time-picker 📅 date-picker ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Eralmidia
Copy link

Eralmidia commented Apr 24, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

We are currently trying to implement the date/time pickers, and due to how older components work, we are forced to use the dropdown mode to keep the user experience the same. However, there are a couple of features we need in order to use this.

Describe the solution you'd like

  1. When in drop down mode, it seems like the cancel and today buttons are not shown (not sure if this is a bug?). We can't really use this component without it (well, the cancel button isn't important, but the today button is). Also, if possible, it would be great to have the ability to choose whether clicking the today button should actually select today and close the dropdown, or simply move the date picker view to today.
  2. It would be nice to have an option to add custom buttons to the bottom of the datepicker, with ng-content or similar, in order to enable custom logic. For instance, say we want a "quick selection" button for the day exactly 1 month ago.

Of cource, if 2 were implemented, then 1 isn't really an issue, as long as there are methods to select today.
@SlavUI SlavUI self-assigned this Apr 25, 2019
@StefanIvanov
Copy link
Contributor

Hi @Eralmidia as we were using a dialog to display the picker before, the buttons came from it and we saw it as sort of a modal experience that required confirming/canceling and other actions but once we moved away from that we thought the buttons may not be necessary anymore but you have a very good point about the today/now button. And our approach for that will be template-able of course as it is for the dialog. Since drop downs close upon selection by default we will keep that behavior as default but will provide a mechanism to cancel the closing event of the overlay that contains the picker.

@Eralmidia
Copy link
Author

Hi @StefanIvanov Templateable buttons and the ability to cancel close sounds great.

We have tried half a dozen pickers over the years. Seems like we finally will get one which has all the features we need 👍

@StefanIvanov
Copy link
Contributor

StefanIvanov commented May 7, 2019 •
edited
Loading

I have updated the spec to be inclusive of the requests mentioned above. I have also made consistent updates to the time picker spec.

@kdinev @bkulov @SlavUI the spec updates are pending your approvals

@SAndreeva SAndreeva added 🛠️ status: in-development Issues and PRs with active development on them 🕐 time-picker labels May 15, 2019
SAndreeva added a commit that referenced this issue May 30, 2019
@SAndreeva
feat(pickers): custom buttons functionality #4647
d0e44a0
@SAndreeva SAndreeva mentioned this issue May 30, 2019
Merged
14 tasks
SAndreeva added a commit that referenced this issue May 30, 2019
@SAndreeva
chore(*): fix lint errors #4647
8fcebe9
SAndreeva added a commit that referenced this issue May 31, 2019
@SAndreeva
chore(*): remove trailing white space #4647
d7803e9
SAndreeva added a commit that referenced this issue May 31, 2019
@SAndreeva
feat(pickers): add custom styling ability #4647
d2ce32f
@SAndreeva SAndreeva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels May 31, 2019
SAndreeva added a commit that referenced this issue Jun 3, 2019
@SAndreeva
feat(pickers): remove css and unify retemplating approach #4647
6a81089
SAndreeva added a commit that referenced this issue Jun 3, 2019
@SAndreeva
chore(*): update README.md and CHANGELOG.md #4647
f902daa
@Eralmidia
Copy link
Author

@SAndreeva Hi Stefana. Do you have an ETA for the release of this one? 😃

@SAndreeva
Copy link
Contributor

Hi, I suppose it will make it in 7.3.4

@Eralmidia
Copy link
Author

Thanks

SAndreeva added a commit that referenced this issue Jun 6, 2019
@SAndreeva
chore(*): address some review comments #4647
bdb3ddc
SAndreeva added a commit that referenced this issue Jun 6, 2019
@SAndreeva
chore(*): more code improvements #4647
6f5ba2a
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
chore(*): update code snippet in README.md #4647
b4a77eb
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
feat(pickers): custom buttons functionality #4647
efcaf6d
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
chore(*): fix lint errors #4647
bc1ba3e
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
chore(*): remove trailing white space #4647
43eb238
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
feat(pickers): add custom styling ability #4647
b52a5c2
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
feat(pickers): remove css and unify retemplating approach #4647
ae5b70f
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
chore(*): update README.md and CHANGELOG.md #4647
82e8640
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
chore(*): address some review comments #4647
4bb4d8e 
# Conflicts:
#	CHANGELOG.md
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
chore(*): more code improvements #4647
ab064a4
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
chore(*): update code snippet in README.md #4647
a01ac1a
@SAndreeva SAndreeva mentioned this issue Jun 7, 2019
Merged
14 tasks
SAndreeva added a commit that referenced this issue Jun 7, 2019
@SAndreeva
fix(*): build error #4647
4ae070e
bkulov pushed a commit that referenced this issue Jun 10, 2019
@SAndreeva @bkulov
Date/time picker: action buttons customization (#4942)
a2cf288 
* feat(pickers): custom buttons functionality #4647

* chore(*): fix lint errors #4647

* chore(*): remove trailing white space #4647

* feat(pickers): add custom styling ability #4647

* feat(pickers): remove css and unify retemplating approach #4647

* chore(*): update README.md and CHANGELOG.md #4647

* chore(*): address some review comments #4647

* chore(*): more code improvements #4647

* fix(time-picker): Fixed failing test #4942

* chore(*): update code snippet in README.md #4647

* fix(*): build error #4647
@sboykova sboykova mentioned this issue Jun 10, 2019
Merged
bkulov pushed a commit that referenced this issue Jun 11, 2019
@SAndreeva @bkulov
Date/time picker: action buttons customization - master (#5027)
763dea9 
* feat(pickers): custom buttons functionality #4647

* chore(*): fix lint errors #4647

* chore(*): remove trailing white space #4647

* feat(pickers): add custom styling ability #4647

* feat(pickers): remove css and unify retemplating approach #4647

* chore(*): update README.md and CHANGELOG.md #4647

* chore(*): address some review comments #4647

# Conflicts:
#	CHANGELOG.md

* chore(*): more code improvements #4647

* fix(time-picker): Fixed failing test #4942

* chore(*): update code snippet in README.md #4647
@sboykova sboykova mentioned this issue Jun 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanIvanov StefanIvanov

@bkulov bkulov

@SAndreeva SAndreeva

@SlavUI SlavUI

Labels
📈 enhancement 🕐 time-picker 📅 date-picker ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Date/time picker: action buttons customization - master IgniteUI/igniteui-angular
5 participants
@StefanIvanov @bkulov @SAndreeva @Eralmidia @SlavUI