refactor(grids): lint errors updates#10506

tishko0 · tishko0 · commit b2233a18f2db · 2021-11-16T17:46:29.000+02:00
diff --git a/projects/igniteui-angular/src/lib/carousel/carousel.component.ts b/projects/igniteui-angular/src/lib/carousel/carousel.component.ts
@@ -796,7 +796,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
     public play() {
         if (!this.playing) {
             this.playing = true;
-            this.onCarouselPlaying.emit(this);
+            this.carouselPlaying.emit(this);
             this.restartInterval();
             this.stoppedByInteraction = false;
         }
@@ -815,7 +815,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
     public stop() {
         if (this.pause) {
             this.playing = false;
-            this.onCarouselPaused.emit(this);
+            this.carouselPaused.emit(this);
             this.resetInterval();
         }
     }
@@ -944,7 +944,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
             } else {
                 this.currentItem = slide;
             }
-            this.onSlideChanged.emit({ carousel: this, slide });
+            this.slideChanged.emit({ carousel: this, slide });
             this.restartInterval();
         }
     }
@@ -967,7 +967,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
             diff.forEachAddedItem((record: IterableChangeRecord<IgxSlideComponent>) => {
                 const slide = record.item;
                 slide.total = this.total;
-                this.onSlideAdded.emit({ carousel: this, slide });
+                this.slideAdded.emit({ carousel: this, slide });
                 if (slide.active) {
                     this.currentItem = slide;
                 }
@@ -976,7 +976,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
 
             diff.forEachRemovedItem((record: IterableChangeRecord<IgxSlideComponent>) => {
                 const slide = record.item;
-                this.onSlideRemoved.emit({ carousel: this, slide });
+                this.slideRemoved.emit({ carousel: this, slide });
                 if (slide.active) {
                     slide.active = false;
                     this.currentItem = this.get(slide.index < this.total ? slide.index : this.total - 1);
diff --git a/projects/igniteui-angular/src/lib/core/displayDensity.ts b/projects/igniteui-angular/src/lib/core/displayDensity.ts
@@ -66,7 +66,7 @@ export class DisplayDensityBase implements DoCheck, OnInit {
                 newDensity: this._displayDensity
             };
 
-            this.onDensityChanged.emit(densityChangedArgs);
+            this.densityChanged.emit(densityChangedArgs);
         }
     }
 
@@ -98,7 +98,7 @@ export class DisplayDensityBase implements DoCheck, OnInit {
                 newDensity: this.displayDensityOptions.displayDensity
             };
 
-            this.onDensityChanged.emit(densityChangedArgs);
+            this.densityChanged.emit(densityChangedArgs);
             this.oldDisplayDensityOptions = Object.assign(this.oldDisplayDensityOptions, this.displayDensityOptions);
         }
     }
diff --git a/projects/igniteui-angular/src/lib/grids/common/crud.service.ts b/projects/igniteui-angular/src/lib/grids/common/crud.service.ts
@@ -359,8 +359,7 @@ export class IgxRowCrudState extends IgxCellCrudState {
 
             this.grid.transactions.endPending(false);
 
-            const parentId = this.getParentRowId();
-            this.grid.gridAPI.addRowToData(this.row.newData ?? this.row.data, parentId);
+            this.grid.gridAPI.addRowToData(this.row.newData ?? this.row.data);
             this.grid.triggerPipes();
 
             nonCancelableArgs = this.rowEditDone(null, event);
diff --git a/projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts b/projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts
@@ -203,7 +203,7 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
             this._filteringChanged = this.grid.filteringExpressionsTreeChange.pipe(takeUntil(this.destroy$)).subscribe(() => {
                 this.init();
             });
-            this._densityChanged = this.grid.onDensityChanged.pipe(takeUntil(this.destroy$)).subscribe(() => {
+            this._densityChanged = this.grid.densityChanged.pipe(takeUntil(this.destroy$)).subscribe(() => {
                 this.cdr.detectChanges();
             });
             this._columnMoved = this.grid.columnMovingEnd.pipe(takeUntil(this.destroy$)).subscribe(() => {
diff --git a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts
@@ -3339,7 +3339,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
             this.calculateGridSizes(false);
         });
 
-        this.onDensityChanged.pipe(destructor).subscribe(() => {
+        this.densityChanged.pipe(destructor).subscribe(() => {
             this.crudService.endEdit(false);
             this.summaryService.summaryHeight = 0;
             this.notifyChanges(true);
@@ -5615,10 +5615,10 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
             visibleColIndex = -1;
         }
         // If the target row is pinned no need to scroll as well.
-        const shouldScrollVertically = this.navigation.shouldPerformVerticalScroll(rowIndex, visibleColIndex);
+        const shouldScrollVertically = this.navigation.shouldPerformVerticalScroll(rowIndex);
         const shouldScrollHorizontally = this.navigation.shouldPerformHorizontalScroll(visibleColIndex, rowIndex);
         if (shouldScrollVertically) {
-            this.navigation.performVerticalScrollToCell(rowIndex, visibleColIndex, () => {
+            this.navigation.performVerticalScrollToCell(rowIndex, () => {
                 if (shouldScrollHorizontally) {
                     this.navigation.performHorizontalScrollToCell(visibleColIndex, () =>
                         this.executeCallback(rowIndex, visibleColIndex, cb));
@@ -5629,7 +5629,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
         } else if (shouldScrollHorizontally) {
             this.navigation.performHorizontalScrollToCell(visibleColIndex, () => {
                 if (shouldScrollVertically) {
-                    this.navigation.performVerticalScrollToCell(rowIndex, visibleColIndex, () =>
+                    this.navigation.performVerticalScrollToCell(rowIndex, () =>
                         this.executeCallback(rowIndex, visibleColIndex, cb));
                 } else {
                     this.executeCallback(rowIndex, visibleColIndex, cb);
diff --git a/projects/igniteui-angular/src/lib/grids/grid-mrl-navigation.service.ts b/projects/igniteui-angular/src/lib/grids/grid-mrl-navigation.service.ts
@@ -21,11 +21,11 @@ export class IgxGridMRLNavigationService extends IgxGridNavigationService {
     }
 
     public shouldPerformVerticalScroll(targetRowIndex: number, visibleColIndex: number): boolean {
-        if (!super.shouldPerformVerticalScroll(targetRowIndex, visibleColIndex)) {
+        if (!super.shouldPerformVerticalScroll(targetRowIndex)) {
             return false;
         }
         if (!this.isDataRow(targetRowIndex) || visibleColIndex < 0) {
-            return super.shouldPerformVerticalScroll(targetRowIndex, visibleColIndex);
+            return super.shouldPerformVerticalScroll(targetRowIndex);
         }
 
         const targetRow = super.getRowElementByIndex(targetRowIndex);
@@ -79,7 +79,7 @@ export class IgxGridMRLNavigationService extends IgxGridNavigationService {
     public performVerticalScrollToCell(rowIndex: number, visibleColIndex: number, cb?: () => void) {
         const children = this.parentByChildIndex(visibleColIndex || 0)?.children;
         if (!super.isDataRow(rowIndex) || (children && children.length < 2) || visibleColIndex < 0) {
-            return super.performVerticalScrollToCell(rowIndex, visibleColIndex, cb);
+            return super.performVerticalScrollToCell(rowIndex, cb);
         }
 
         const containerHeight = this.grid.calcHeight ? Math.ceil(this.grid.calcHeight) : 0;
diff --git a/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts b/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts
@@ -209,8 +209,8 @@ export class IgxGridNavigationService {
             || containerHeight && endTopOffset - containerHeight > 5;
     }
 
-    public performVerticalScrollToCell(rowIndex: number, visibleColIndex = -1, cb?: () => void) {
-        if (!this.shouldPerformVerticalScroll(rowIndex, visibleColIndex)) {
+    public performVerticalScrollToCell(rowIndex: number, cb?: () => void) {
+        if (!this.shouldPerformVerticalScroll(rowIndex)) {
             return;
         }
         this.pendingNavigation = true;
@@ -685,7 +685,7 @@ export class IgxGridNavigationService {
             this.grid.visibleColumns.sort((c1, c2) => c1.visibleIndex - c2.visibleIndex)
             .find(c => this.isColumnFullyVisible(c.visibleIndex))?.visibleIndex;
         const column = this.grid.visibleColumns.find((col) => !col.columnLayout && col.visibleIndex === colIndex);
-        const rowInd = rowIndex ? rowIndex : this.grid.rowList.find(r => !this.shouldPerformVerticalScroll(r.index, colIndex))?.index;
+        const rowInd = rowIndex ? rowIndex : this.grid.rowList.find(r => !this.shouldPerformVerticalScroll(r.index))?.index;
         const node = { row: rowInd ?? 0,
             column: column?.visibleIndex ?? 0, level: column?.level ?? 0,
             mchCache: column ? {level: column.level, visibleIndex: column.visibleIndex} : {} as ColumnGroupsCache,
diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts
@@ -400,7 +400,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType,
                 groupedColumns: groupedCols,
                 ungroupedColumns: ungroupedCols
             };
-            this.onGroupingDone.emit(groupingDoneArgs);
+            this.groupingDone.emit(groupingDoneArgs);
         }
     }
 
@@ -985,7 +985,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType,
      */
     public ngOnInit() {
         super.ngOnInit();
-        this.onGroupingDone.pipe(takeUntil(this.destroy$)).subscribe((args) => {
+        this.groupingDone.pipe(takeUntil(this.destroy$)).subscribe((args) => {
             this.crudService.endEdit(false);
             this.summaryService.updateSummaryCache(args);
             this._headerFeaturesWidth = NaN;
diff --git a/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid-navigation.service.ts b/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid-navigation.service.ts
@@ -93,15 +93,15 @@ export class IgxHierarchicalGridNavigationService extends IgxGridNavigationServi
         super.navigateInBody(rowIndex, visibleColIndex, cb);
     }
 
-    public shouldPerformVerticalScroll(index, visibleColumnIndex = -1, isNext?) {
+    public shouldPerformVerticalScroll(index, isNext?) {
         const targetRec = this.grid.dataView[index];
         if (this.grid.isChildGridRecord(targetRec)) {
             const scrollAmount = this.grid.verticalScrollContainer.getScrollForIndex(index, !isNext);
             const currScroll = this.grid.verticalScrollContainer.getScroll().scrollTop;
             const shouldScroll = !isNext ? scrollAmount > currScroll : currScroll < scrollAmount;
             return shouldScroll;
         } else {
-            return super.shouldPerformVerticalScroll(index, visibleColumnIndex);
+            return super.shouldPerformVerticalScroll(index);
         }
     }
 
@@ -141,9 +141,9 @@ export class IgxHierarchicalGridNavigationService extends IgxGridNavigationServi
      * @param cb  Optional.Callback function called when operation is complete.
      */
     protected _handleScrollInChild(rowIndex: number, isNext?: boolean, cb?: () => void) {
-        const shouldScroll = this.shouldPerformVerticalScroll(rowIndex, -1, isNext);
+        const shouldScroll = this.shouldPerformVerticalScroll(rowIndex, isNext);
         if (shouldScroll) {
-            this.grid.navigation.performVerticalScrollToCell(rowIndex, -1, () => {
+            this.grid.navigation.performVerticalScrollToCell(rowIndex, () => {
                 this.positionInParent(rowIndex, isNext, cb);
             });
         } else {
diff --git a/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts b/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts
@@ -416,7 +416,7 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
 
         if (this.parent) {
             this._displayDensity = this.rootGrid._displayDensity;
-            this.rootGrid.onDensityChanged.pipe(takeUntil(this.destroy$)).subscribe(() => {
+            this.rootGrid.densityChanged.pipe(takeUntil(this.destroy$)).subscribe(() => {
                 this._displayDensity = this.rootGrid._displayDensity;
                 this.notifyChanges(true);
                 this.cdr.markForCheck();
diff --git a/projects/igniteui-angular/src/lib/grids/summaries/grid-summary.ts b/projects/igniteui-angular/src/lib/grids/summaries/grid-summary.ts
@@ -169,8 +169,8 @@ export class IgxNumberSummaryOperand extends IgxSummaryOperand {
      *
      * @memberof IgxNumberSummaryOperand
      */
-    public operate(data: any[] = [], allData: any[] = [], fieldName?: string): IgxSummaryResult[] {
-        const result = super.operate(data, allData, fieldName);
+    public operate(data: any[] = []): IgxSummaryResult[] {
+        const result = super.operate(data);
         result.push({
             key: 'min',
             label: 'Min',
@@ -257,8 +257,8 @@ export class IgxDateSummaryOperand extends IgxSummaryOperand {
      *
      * @memberof IgxDateSummaryOperand
      */
-    public operate(data: any[] = [], allData: any[] = [],  fieldName?: string): IgxSummaryResult[] {
-        const result = super.operate(data, allData, fieldName);
+    public operate(data: any[] = []): IgxSummaryResult[] {
+        const result = super.operate(data);
         result.push({
             key: 'earliest',
             label: 'Earliest',
@@ -310,8 +310,8 @@ export class IgxTimeSummaryOperand extends IgxSummaryOperand {
     /**
      * @memberof IgxTimeSummaryOperand
      */
-    public operate(data: any[] = [], allData: any[] = [],  fieldName?: string): IgxSummaryResult[] {
-        const result = super.operate(data, allData, fieldName);
+    public operate(data: any[] = []): IgxSummaryResult[] {
+        const result = super.operate(data);
         result.push({
             key: 'earliest',
             label: 'Earliest',
diff --git a/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts b/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts
@@ -595,9 +595,9 @@ export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridTy
      * @memberof IgxTreeGridComponent
      */
     // TODO: remove evt emission
-    public addRow(data: any, parentRowID?: any) {
+    public addRow(data: any) {
         this.crudService.endEdit(true);
-        this.gridAPI.addRowToData(data, parentRowID);
+        this.gridAPI.addRowToData(data);
 
         this.rowAddedNotifier.next({ data });
         this.pipeTrigger++;
diff --git a/projects/igniteui-angular/src/lib/services/excel/excel-files.ts b/projects/igniteui-angular/src/lib/services/excel/excel-files.ts
@@ -385,12 +385,8 @@ export class WorksheetFile implements IExcelFile {
  * @hidden
  */
 export class StyleFile implements IExcelFile {
-    public writeElement(folder: JSZip, worksheetData: WorksheetData) {
-        const hasNumberValues = worksheetData.dataDictionary && worksheetData.dataDictionary.hasNumberValues;
-        const hasDateValues = worksheetData.dataDictionary && worksheetData.dataDictionary.hasDateValues;
-        const isHierarchicalGrid = worksheetData.data[0]?.type === ExportRecordType.HierarchicalGridRecord;
-
-        folder.file('styles.xml', ExcelStrings.getStyles(hasNumberValues, hasDateValues, isHierarchicalGrid));
+    public writeElement(folder: JSZip) {
+        folder.file('styles.xml', ExcelStrings.getStyles());
     }
 }
 
diff --git a/projects/igniteui-angular/src/lib/tree/tree.component.ts b/projects/igniteui-angular/src/lib/tree/tree.component.ts
@@ -385,7 +385,7 @@ export class IgxTreeComponent extends DisplayDensityBase implements IgxTree, OnI
             this.expandToNode(this.navService.activeNode);
             this.scrollNodeIntoView(node?.header?.nativeElement);
         });
-        this.onDensityChanged.pipe(takeUntil(this.destroy$)).subscribe(() => {
+        this.densityChanged.pipe(takeUntil(this.destroy$)).subscribe(() => {
             requestAnimationFrame(() => {
                 this.scrollNodeIntoView(this.navService.activeNode?.header.nativeElement);
             });

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ export class DisplayDensityBase implements DoCheck, OnInit {`
`66`	`66`	`newDensity: this._displayDensity`
`67`	`67`	`};`
`68`	`68`
`69`		`- this.onDensityChanged.emit(densityChangedArgs);`
	`69`	`+ this.densityChanged.emit(densityChangedArgs);`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`
`@@ -98,7 +98,7 @@ export class DisplayDensityBase implements DoCheck, OnInit {`
`98`	`98`	`newDensity: this.displayDensityOptions.displayDensity`
`99`	`99`	`};`
`100`	`100`
`101`		`- this.onDensityChanged.emit(densityChangedArgs);`
	`101`	`+ this.densityChanged.emit(densityChangedArgs);`
`102`	`102`	`this.oldDisplayDensityOptions = Object.assign(this.oldDisplayDensityOptions, this.displayDensityOptions);`
`103`	`103`	`}`
`104`	`104`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,11 @@ export class IgxGridMRLNavigationService extends IgxGridNavigationService {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public shouldPerformVerticalScroll(targetRowIndex: number, visibleColIndex: number): boolean {`
`24`		`- if (!super.shouldPerformVerticalScroll(targetRowIndex, visibleColIndex)) {`
	`24`	`+ if (!super.shouldPerformVerticalScroll(targetRowIndex)) {`
`25`	`25`	`return false;`
`26`	`26`	`}`
`27`	`27`	`if (!this.isDataRow(targetRowIndex) \|\| visibleColIndex < 0) {`
`28`		`- return super.shouldPerformVerticalScroll(targetRowIndex, visibleColIndex);`
	`28`	`+ return super.shouldPerformVerticalScroll(targetRowIndex);`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`const targetRow = super.getRowElementByIndex(targetRowIndex);`
`@@ -79,7 +79,7 @@ export class IgxGridMRLNavigationService extends IgxGridNavigationService {`
`79`	`79`	`public performVerticalScrollToCell(rowIndex: number, visibleColIndex: number, cb?: () => void) {`
`80`	`80`	`const children = this.parentByChildIndex(visibleColIndex \|\| 0)?.children;`
`81`	`81`	`if (!super.isDataRow(rowIndex) \|\| (children && children.length < 2) \|\| visibleColIndex < 0) {`
`82`		`- return super.performVerticalScrollToCell(rowIndex, visibleColIndex, cb);`
	`82`	`+ return super.performVerticalScrollToCell(rowIndex, cb);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`const containerHeight = this.grid.calcHeight ? Math.ceil(this.grid.calcHeight) : 0;`