refactor(stepper): keep up to PR changes

Author: ddaribo

projects/igniteui-angular/src/lib/stepper/stepper.component.spec.ts

@@ -440,11 +440,19 @@ describe('Rendering Tests', () => {
         it('should place the title in the step element according to the specified titlePosition when stepType is set to "full"', () => {
             stepper.orientation = IgxStepperOrientation.Horizontal;
             stepper.stepType = IgxStepType.Full;
+            stepper.titlePosition = null;
             fix.detectChanges();
 
-            let positions = getStepperPositions();
+            //test default title positions
+            for (const step of stepper.steps) {
+                expect(step.titlePosition).toBe(stepper._defaultTitlePosition);
+                expect(step.titlePosition).toBe(IgxStepperTitlePosition.Bottom);
+                expect(step.nativeElement).toHaveClass(`igx-stepper__step--${stepper._defaultTitlePosition}`);
+            }
+
+            const positions = getStepperPositions();
             positions.forEach((pos: IgxStepperTitlePosition) => {
-                stepper.horizontalTitlePosition = pos;
+                stepper.titlePosition = pos;
                 fix.detectChanges();
 
                 for (const step of stepper.steps) {
@@ -453,11 +461,18 @@ describe('Rendering Tests', () => {
             });
 
             stepper.orientation = IgxStepperOrientation.Vertical;
+            stepper.titlePosition = null;
             fix.detectChanges();
 
-            positions = getStepperPositions();
+            //test default title positions
+            for (const step of stepper.steps) {
+                expect(step.titlePosition).toBe(stepper._defaultTitlePosition);
+                expect(step.titlePosition).toBe(IgxStepperTitlePosition.End);
+                expect(step.nativeElement).toHaveClass(`igx-stepper__step--${stepper._defaultTitlePosition}`);
+            }
+
             positions.forEach((pos: IgxStepperTitlePosition) => {
-                stepper.verticalTitlePosition = pos;
+                stepper.titlePosition = pos;
                 fix.detectChanges();
 
                 for (const step of stepper.steps) {
@@ -544,20 +559,11 @@ describe('Rendering Tests', () => {
                 testAnimationBehvior(val, fix, false);
             }
 
-            const dummyTestValues = [-1, 'sampleString', [], {}];
-
-            for (const val of dummyTestValues) {
-                expect(() => {
-                    fix.componentInstance.animationDuration = val as any;
-                    testAnimationBehvior(val, fix, false);
-                }).toThrow();
-            }
-
-            const fallbackToDefaultValues = [0, null];
+            const fallbackToDefaultValues = [-1, 0, null, undefined, 'sampleString', [], {}];
             for (const val of fallbackToDefaultValues) {
                 fix.componentInstance.animationDuration = val as any;
                 fix.detectChanges();
-                expect(stepper.animationDuration).withContext('Set 0/null animation duration and verify default value')
+                expect(stepper.animationDuration)
                     .toBe((stepper as any)._defaultAnimationDuration);
                 testAnimationBehvior(val, fix, false);
             }
@@ -926,9 +932,7 @@ describe('Stepper service unit tests', () => {
         mockElementRef = { nativeElement: mockElement };
 
         mockAnimationBuilder = {
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
             build: (_a: AnimationMetadata | AnimationMetadata[]) => ({
-                // eslint-disable-next-line @typescript-eslint/no-unused-vars
                 create: (_e: any, _opt?: AnimationOptions) => ({
                     onDone: (_fn: any) => { },
                     onStart: (_fn: any) => { },
@@ -950,7 +954,6 @@ describe('Stepper service unit tests', () => {
             })
         };
 
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         mockPlatform = { isIOS: false };
 
         mockDocument = {
@@ -962,14 +965,12 @@ describe('Stepper service unit tests', () => {
             removeEventListener: (_type: string, _listener: (this: HTMLElement, ev: MouseEvent) => any) => { }
         };
 
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         mockDir = {
             value: (): Direction => 'rtl',
             document: () => mockDocument,
             rtl: () => true
         };
 
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         mockCdr = {
             markForCheck: (): void => { },
             detach: (): void => { },
@@ -989,16 +990,8 @@ describe('Stepper service unit tests', () => {
         }
     });
 
-    it('should properly register the specified stepper', () => {
-        stepperService = new IgxStepperService();
-        expect((stepperService as any).stepper).toBeFalsy();
-        stepperService.register(stepper);
-        expect((stepperService as any).stepper).toEqual(stepper);
-    });
-
     it('should expand a step by activating it and firing the step\'s activeChange event', () => {
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Horizontal);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Horizontal);
         spyOnProperty(stepper, 'steps', 'get').and.returnValue(steps);
 
         stepperService.activeStep = steps[0];
@@ -1015,12 +1008,10 @@ describe('Stepper service unit tests', () => {
         expect(steps[1].activeChange.emit).toHaveBeenCalledWith(true);
 
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Vertical);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Vertical);
         stepperService.expand(steps[0]);
 
         expect(stepperService.activeStep).toBe(steps[0]);
-        expect(steps[0].activeChange.emit).toHaveBeenCalledTimes(1);
-        expect(steps[0].activeChange.emit).toHaveBeenCalledWith(true);
+        expect(steps[0].activeChange.emit).toHaveBeenCalledOnceWith(true);
 
         const testValues = [null, undefined, [], {}, 'sampleString'];
 
@@ -1033,7 +1024,6 @@ describe('Stepper service unit tests', () => {
 
     it('should expand a step through API by activating it and firing the step\'s activeChange event', () => {
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Horizontal);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Horizontal);
         spyOnProperty(stepper, 'steps', 'get').and.returnValue(steps);
 
         stepperService.activeStep = steps[0];
@@ -1044,13 +1034,10 @@ describe('Stepper service unit tests', () => {
         stepperService.expandThroughApi(steps[1]);
 
         expect(stepperService.activeStep).toBe(steps[1]);
-        expect(steps[0].activeChange.emit).toHaveBeenCalledTimes(1);
-        expect(steps[0].activeChange.emit).toHaveBeenCalledWith(false);
-        expect(steps[1].activeChange.emit).toHaveBeenCalledTimes(1);
-        expect(steps[1].activeChange.emit).toHaveBeenCalledWith(true);
+        expect(steps[0].activeChange.emit).toHaveBeenCalledOnceWith(false);
+        expect(steps[1].activeChange.emit).toHaveBeenCalledOnceWith(true);
 
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Vertical);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Vertical);
         stepperService.expandThroughApi(steps[0]);
 
         expect(stepperService.activeStep).toBe(steps[0]);
@@ -1070,7 +1057,6 @@ describe('Stepper service unit tests', () => {
 
     it('should collapse the currently active step and fire the change event', () => {
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Horizontal);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Horizontal);
         spyOnProperty(stepper, 'steps', 'get').and.returnValue(steps);
 
         stepperService.previousActiveStep = steps[0];
@@ -1088,12 +1074,10 @@ describe('Stepper service unit tests', () => {
         expect(stepperService.collapsingSteps).not.toContain(steps[0]);
         expect(stepperService.activeStep).not.toBe(steps[0]);
         expect(stepperService.activeStep).toBe(steps[1]);
-        expect(steps[0].activeChange.emit).toHaveBeenCalledTimes(1);
-        expect(steps[0].activeChange.emit).toHaveBeenCalledWith(false);
+        expect(steps[0].activeChange.emit).toHaveBeenCalledOnceWith(false);
         expect(steps[1].activeChange.emit).not.toHaveBeenCalled();
 
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Vertical);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Vertical);
 
         stepperService.previousActiveStep = steps[1];
         stepperService.activeStep = steps[0];
@@ -1108,8 +1092,7 @@ describe('Stepper service unit tests', () => {
         expect(stepperService.activeStep).not.toBe(steps[1]);
         expect(stepperService.activeStep).toBe(steps[0]);
 
-        expect(steps[1].activeChange.emit).toHaveBeenCalledTimes(1);
-        expect(steps[1].activeChange.emit).toHaveBeenCalledWith(false);
+        expect(steps[1].activeChange.emit).toHaveBeenCalledOnceWith(false);
         expect(steps[0].activeChange.emit).not.toHaveBeenCalledTimes(2);
 
         const testValues = [null, undefined, [], {}, 'sampleString'];
@@ -1146,7 +1129,6 @@ describe('Stepper service unit tests', () => {
 
     it('should determine the steps that should be disabled in linear mode based on the validity of the active step', () => {
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Horizontal);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Horizontal);
         spyOnProperty(stepper, 'steps').and.returnValue(steps);
 
         for (const step of steps) {
@@ -1192,7 +1174,6 @@ describe('Stepper service unit tests', () => {
 
     it('should emit activating event', () => {
         spyOnProperty(stepper, 'orientation', 'get').and.returnValue(IgxStepperOrientation.Horizontal);
-        expect(stepper.orientation).toBe(IgxStepperOrientation.Horizontal);
         spyOnProperty(stepper, 'steps').and.returnValue(steps);
         const activeChangingSpy = spyOn(stepper.activeStepChanging, 'emit');
         stepperService.activeStep = steps[0];