Skip to content

IgxGrid: clearing the sorting expressions should not affect the gird's grouping #10765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viktorkombov opened this issue Dec 23, 2021 · 4 comments · Fixed by #10336
Closed

IgxGrid: clearing the sorting expressions should not affect the gird's grouping #10765

viktorkombov opened this issue Dec 23, 2021 · 4 comments · Fixed by #10336
Assignees
Labels
grid: groupby grid: sorting 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@viktorkombov
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If the sorting expressions are cleared with the clearSort method, the grid's grouping will be in messed up state.

sortgroup1

Describe the solution you'd like

The grid's grouping shoud be not affected if the clearSort method is executed.

@viktorkombov
Copy link
Contributor Author

Related to #9674

@Eralmidia
Copy link

@kdinev Will this be prioritized soon? Its a rather major issue, as now we can't really trust the grouping, because there might very well be that one group doesn't contain every row it should.

@kdinev
Copy link
Member

kdinev commented Feb 4, 2022

@ChronosSF Could you comment on this issue. I know that sorting and grouping expressions are connected, since grouping is a superset of sorting, but since the sorting and grouping expression collections are different, wouldn't this be easily achievable?

@hanastasov
Copy link
Contributor

@kdinev Regarding #9674 we started decoupling sorting from grouping. Materializing the decoupling in code is not much, but not sure how much adittional effort is needed to complete it and add anything neccessary to fix tests. bugs. etc.

@hanastasov hanastasov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 22, 2022
@ddincheva ddincheva added status: resolved and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 12, 2022
@kdinev kdinev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed status: resolved labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: groupby grid: sorting 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants