Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate grouping and sorting #11355

Merged
merged 14 commits into from
Apr 12, 2022
Merged

Separate grouping and sorting #11355

merged 14 commits into from
Apr 12, 2022

Conversation

ddincheva
Copy link
Contributor

@ddincheva ddincheva commented Apr 7, 2022 •
edited
Loading

Closes #11269
Closes #10765
Closes #9674

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

ddincheva added 13 commits April 4, 2022 10:15
@ddincheva
feat(GroupBy): handle groupBy sorting without updating sorting expres…
b5cfa6a 
…sions #9674
@ddincheva
feat(Sorting): remove sortIndex when single sorting mode is enabled #…
dbe2440 
…9674
@ddincheva
feat(Sorting): grid sorting should not affect group by state #9674
51a6c56
@ddincheva
feat(*): update sort pipe to work based on group and sorting expressi…
2c519a3 
…ons #9674
@ddincheva
fix(*): fix the iissues with hierarchical and tree grid #9674
70cc291
@ddincheva
feat(TGrid): remove the binding logic between sorting expr and groupBy …
7ca5130 
…#9674
@ddincheva
chore(*): update samples with sortingOption prop
041d519
@ddincheva
chore(*): fix groupBy tests
a4ebae6
@ddincheva
chore(*): fix buildig errors
df3504d
@ddincheva
chore(*): fix failing test due to the regression in excell export
087739a
@ddincheva
chore(*): fix the thrown error when trying to group by nonexisting co…
c5e4d64 
…lumn
@ddincheva
chore(*): fix wrong test expectation
0892262
@ddincheva
chore(*): add some additional test to verify separation of grouping a…
7ad0d9e 
…nd sorting
This was referenced Apr 12, 2022
Closed
Closed
@ddincheva ddincheva marked this pull request as ready for review April 12, 2022 07:33
@hanastasov hanastasov merged commit cf7495d into kdragieva/grid-sorting-master Apr 12, 2022
@hanastasov hanastasov deleted the ddincheva/groupingSorting-13.1.x branch April 12, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddincheva @hanastasov