Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select item built-in prefix/suffix support #13208

Closed
damyanpetev opened this issue Jul 5, 2023 · 0 comments · Fixed by #13256
Closed

Select item built-in prefix/suffix support #13208

damyanpetev opened this issue Jul 5, 2023 · 0 comments · Fixed by #13256
Assignees
Labels
📈 enhancement select Select component 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@damyanpetev
Copy link
Member

Is your feature request related to a problem? Please describe.

Per the title - it would be beneficial both functionality and consistency wise if the select items support the same prefix and suffix projection their base dropdown item does.
Related to #8656 that did the same for the Dropdown items
Also the Web Components Select item already has prefix/suffix (again inherited from the dropdown item).

Describe the solution you'd like

Would like similar internal structure as the dropdown item the select item inherits that has slots to project prefix/suffix. Ideally, after evaluation, it'd be nice if the current setup is altered in a way that won't affect any existing app usage and can be delivered as an enhancement.

Describe alternatives you've considered

I guess we can do what the samples do, which is not pretty at all. The sample under header/footer section is clearly meant to be a suffix:
image
But it's done with CSS:

:host ::ng-deep {
    igx-select-item.select__entry {
        display: flex;
        align-items: center;
        justify-content: space-between;

        span {
            display: flex;
            padding: 8px;
            justify-content: space-between;
            width: 100%;
        }
    }

Where the inner span is actually span.igx-drop-down__inner - not something explicitly intended for users to style.

Additional context

Add any other context or screenshots about the feature request here.

@desig9stein desig9stein added 👀 status: in-review Issue is currently being reviewed 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new 👀 status: in-review Issue is currently being reviewed labels Jul 10, 2023
@desig9stein desig9stein added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 14, 2023
simeonoff added a commit that referenced this issue Jul 18, 2023
* feat(dropdown): support igxPrefix and igxSuffix directives in the context of the dropdown items
Closes #13208
---------

Co-authored-by: Silvia Ivanova <[email protected]>
Co-authored-by: Simeon Simeonoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 enhancement select Select component 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants