Skip to content

Select: Adding support for items suffix and prefix #13256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simeonoff merged 12 commits into from
Jul 18, 2023
Merged

Select: Adding support for items suffix and prefix #13256

simeonoff merged 12 commits into from
Jul 18, 2023

Conversation

@desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Jul 14, 2023 •
edited
Loading

Closes #13208

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein added ❌ status: awaiting-test PRs awaiting manual verification dropdown select Select component version: 16.1.x labels Jul 14, 2023
@desig9stein desig9stein changed the title Mpopov/select prefix suffix Select: Adding support for items suffix and prefix Jul 14, 2023
SisIvanova
SisIvanova previously approved these changes Jul 18, 2023
View reviewed changes
simeonoff
simeonoff requested changes Jul 18, 2023
View reviewed changes
@simeonoff simeonoff self-assigned this Jul 18, 2023
@simeonoff simeonoff self-requested a review July 18, 2023 08:00
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 18, 2023
@desig9stein @simeonoff
Update CHANGELOG.md
7893fef 
Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
@simeonoff simeonoff merged commit 47b94e2 into master Jul 18, 2023
@simeonoff simeonoff deleted the mpopov/select-prefix-suffix branch July 18, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

@SisIvanova SisIvanova SisIvanova left review comments

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

Assignees

@damyanpetev damyanpetev

@simeonoff simeonoff

Labels

dropdown select Select component version: 16.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Select item built-in prefix/suffix support

5 participants

@desig9stein @simeonoff @SisIvanova @damyanpetev