Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor switch and radio to inherit from checkbox #13563

Closed
kdinev opened this issue Oct 18, 2023 · 0 comments · Fixed by #13451
Closed

Refactor switch and radio to inherit from checkbox #13563

kdinev opened this issue Oct 18, 2023 · 0 comments · Fixed by #13451
Assignees
@kdinev
Labels
checkbox optimization radio-button radio-group refactoring switch 🧰 feature-request version: 17.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Oct 18, 2023

Is your feature request related to a problem? Please describe.

There's a lot of repeated code in switch, radio and checkbox components.

Describe the solution you'd like

Make igx-checkbox the base component and igx-switch and igx-radio to inherit from it.
@kdinev kdinev self-assigned this Oct 18, 2023
This was referenced Oct 18, 2023
Merged
Merged
Merged
@kdinev kdinev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them 🆕 status: new labels Oct 20, 2023
@kdinev kdinev mentioned this issue Oct 20, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdinev kdinev

Labels
checkbox optimization radio-button radio-group refactoring switch 🧰 feature-request version: 17.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(i18n, util): tree shaking i18n IgniteUI/igniteui-angular
1 participant
@kdinev