Skip to content

refactor(i18n, util): tree shaking i18n #13451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Oct 26, 2023
Merged

refactor(i18n, util): tree shaking i18n #13451

merged 57 commits into from
Oct 26, 2023

Conversation

kdinev
Copy link
Member

@kdinev kdinev commented Sep 11, 2023 •
edited
Loading

Closes #13562 Closes #13563

NOTE: The switch and radio refactoring, as well as the igniteui-angular/animations stuff have already been reviewed. What is not yet reviewed is the i18n and util optimizations.

TODO: Migrations for igniteui-angular/animations.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD
  • Refactoring

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@kdinev kdinev marked this pull request as draft September 11, 2023 08:37
@kdinev kdinev requested a review from damyanpetev September 11, 2023 15:27
@kdinev kdinev marked this pull request as ready for review September 11, 2023 15:27
@kdinev kdinev requested a review from skrustev September 14, 2023 05:39
@kdinev kdinev changed the title refactor(drag and drop): removing renderer2 refactor(*): minor refactoring of tests and lib Sep 20, 2023
@kdinev kdinev changed the title refactor(*): minor refactoring of tests and lib refactor(i18n, util): tree shaking i18n Oct 18, 2023
@kdinev kdinev requested a review from rkaraivanov October 20, 2023 07:12
rkaraivanov
rkaraivanov previously approved these changes Oct 26, 2023
View reviewed changes
@kdinev kdinev merged commit 94db640 into master Oct 26, 2023
@kdinev kdinev deleted the bundle-test-extended branch October 26, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@rkaraivanov rkaraivanov rkaraivanov left review comments

@skrustev skrustev Awaiting requested review from skrustev

Assignees
No one assigned
Labels
animations optimization refactoring 🔣 i18n version: 17.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor switch and radio to inherit from checkbox Improve package tree-shaking
3 participants
@kdinev @damyanpetev @rkaraivanov