Skip to content

igx-timepicker In dropdown mode if we click cancel button without selecting any value null values are displaying #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjPrajwal opened this issue Jan 20, 2020 · 12 comments · Fixed by #6554 or #6742
Assignees
Labels
🐛 bug Any issue that describes a bug 🕐 time-picker 🧨 severity: medium version: 8.1.x version: 8.2.x version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@sjPrajwal
Copy link

Description

In Dropdown mode if we click cancel button without selecting any value null values are displaying and after that can't select any time.

  • igniteui-angular version: 4.3.3
  • browser: Chrome

Steps to reproduce

Active dropdown mode and give min and max values

  1. open the timepicker in dropdown mode
  2. click on cancel button and notice the input field value, null will display
  3. again clear field and try to select the time again still it will display null.

Result

on cancel, time picker taking null values

Expected result

on cancel, time picker shouldn't take any values.

Attachments

Attach a sample if available, and screenshots, if applicable.

@Lipata
Copy link
Member

Lipata commented Jan 20, 2020

Hi, @sjPrajwal.

I'm trying to reproduce your problem and I'm using the following demo. When I follow your steps I see an error, but in the input I see the following value: NaN:NaN AM. Please tell me if this is what you see, or if the problem is different, please modify the demo that I'm sending you. Thank you in advance!

@sjPrajwal
Copy link
Author

sjPrajwal commented Jan 20, 2020 via email

@sjPrajwal
Copy link
Author

Hi @Lipata @jackofdiamond5 ,
any updates on the issue..?

@jackofdiamond5
Copy link
Member

Hi @sjPrajwal,

Please excuse our delayed response. We have moved this issue to our next sprint where we will take a closer look at how we may fix it. In the meantime, we remain open for any additional questions or comments you might have.

@jackofdiamond5 jackofdiamond5 added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 28, 2020
jackofdiamond5 added a commit that referenced this issue Jan 28, 2020
# Conflicts:
#	src/app/time-picker/time-picker.sample.html
#	src/app/time-picker/time-picker.sample.ts
@jackofdiamond5 jackofdiamond5 added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 28, 2020
@sjPrajwal
Copy link
Author

Hi @jackofdiamond5 ,
Any updates on the issue reported...?
I am looking status resolved..

@Lipata
Copy link
Member

Lipata commented Feb 5, 2020

Hi, @sjPrajwal. We are currently making code review and verifying the issue. Expect that this will be part of our 8.2.19 and 8.1.24 releases, next Monday.

@sjPrajwal
Copy link
Author

sjPrajwal commented Feb 5, 2020 via email

@Lipata
Copy link
Member

Lipata commented Feb 5, 2020

Hi, @sjPrajwal.

If it is #6585, we are checking it and we will write in the corresponding issue. If the issue you are experiencing is another one and is not also related to the current one, we prefer a new issue with demo (e.g. in StackBlitz). Thank you, @sjPrajwal.

@sjPrajwal
Copy link
Author

sjPrajwal commented Feb 5, 2020 via email

@sjPrajwal
Copy link
Author

Hi @Lipata ,
Any updates regarding this bug??

@Lipata
Copy link
Member

Lipata commented Feb 11, 2020

Hi, @sjPrajwal.

We've currently released 8.2.19 and 8.1.24, the packages that I have mentioned. However, because of the official Angular 9 release last week, we needed to hold some of our PR and first release our Angular 9 compatible version. In addition to that our 8.2.x and 8.1.x and 9.0.x should be synchronized and currently, the fix is not still merged. Please expect the fix in the next versions and thank you for the patience!

@Lipata
Copy link
Member

Lipata commented Feb 19, 2020

@sjPrajwal you can use [email protected] or [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug 🕐 time-picker 🧨 severity: medium version: 8.1.x version: 8.2.x version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
3 participants