-
Notifications
You must be signed in to change notification settings - Fork 160
Determine initial min-max value #6554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2020
Lipata
previously approved these changes
Jan 28, 2020
damyanpetev
requested changes
Jan 29, 2020
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
Outdated
Show resolved
Hide resolved
5065340
to
8fe8dfe
Compare
damyanpetev
reviewed
Feb 5, 2020
projects/igniteui-angular/src/lib/time-picker/time-picker.component.spec.ts
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
previously approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b262f11
to
b8cf294
Compare
damyanpetev
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6494
When the time picker has
minValue
andmaxValue
properties set and is bound to a date object that does not satisfy them, it does not set the internal value and that later on causes the wrong text to be displayed in the editor.So now we determine whether we should use the min or max value for the editor, based on the value that is received through the model and based on whetherminValue
andmaxValue
are set.The same behaviour can be seen with a
null
value passed in to the model. Now the editor will not throw any errors if you have no value or if the value is not within the valid range. This also prevents it from displaying incorrect text.Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes