Skip to content

Determine initial min-max value #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2020
Merged

Determine initial min-max value #6554

merged 5 commits into from
Feb 13, 2020

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jan 28, 2020

Closes #6494

When the time picker has minValue and maxValue properties set and is bound to a date object that does not satisfy them, it does not set the internal value and that later on causes the wrong text to be displayed in the editor.

So now we determine whether we should use the min or max value for the editor, based on the value that is received through the model and based on whether minValue and maxValue are set.

The same behaviour can be seen with a null value passed in to the model. Now the editor will not throw any errors if you have no value or if the value is not within the valid range. This also prevents it from displaying incorrect text.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

Lipata
Lipata previously approved these changes Jan 28, 2020
damyanpetev
damyanpetev previously approved these changes Feb 6, 2020
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 12, 2020
@Lipata Lipata merged commit 88d0dcd into 9.0.x Feb 13, 2020
@Lipata Lipata deleted the bpenkov/fix-6494-master branch February 13, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕐 time-picker version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
5 participants