Skip to content

fix(themes): fixes regression issues in various component themes #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 17, 2018
Merged
11 changes: 8 additions & 3 deletions demos/app/list-performance/sample.component.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
height: 34px;
}

.item > [igxLabel],
.item > .person {
.item>[igxLabel],
.item>.person {
position: absolute;
margin-left: 72px;
}
Expand All @@ -22,4 +22,9 @@
.item .delete-item:hover {
color: crimson;
cursor: pointer;
}
}

.virtualized-items {
position: relative;
overflow: hidden;
}
26 changes: 12 additions & 14 deletions demos/app/list-performance/sample.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,18 @@ <h4 class="sample-title">Performance sample</h4>
</igx-suffix>
</igx-input-group>

<div class="list-sample">
<igx-list>
<igx-list-item [isHeader]="true">Contacts</igx-list-item>
<div [style.height]="'518px'">
<igx-list-item igxRipple="pink" igxRippleTarget=".igx-list__item" *igxFor="let item of data | igxFilter: fo1; scrollOrientation : 'vertical'; containerSize: '500px'; itemSize: '50px'">
<div class="item">
<igx-avatar [src]="item.avatar" roundShape="true"></igx-avatar>
<span igxLabel>{{item.text}}</span>
<igx-icon name="star" [class.favorite]="item.favorite"></igx-icon>
</div>
</igx-list-item>
</div>
</igx-list>
</div>
<igx-list>
<igx-list-item [isHeader]="true">Contacts</igx-list-item>
<div class="virtualized-items">
<igx-list-item igxRipple="pink" igxRippleTarget=".igx-list__item" *igxFor="let item of data | igxFilter: fo1; scrollOrientation : 'vertical'; containerSize: '500px'; itemSize: '50px'">
<div class="item">
<igx-avatar [src]="item.avatar" roundShape="true"></igx-avatar>
<span igxLabel>{{item.text}}</span>
<igx-icon name="star" [class.favorite]="item.favorite"></igx-icon>
</div>
</igx-list-item>
</div>
</igx-list>

</article>
</div>
1 change: 0 additions & 1 deletion src/core/styles/base/_normalize.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ html input[disabled] {
cursor: default;
}

button,
input[type='number']::-webkit-outer-spin-button {
height: auto;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
%display-container {
display: inherit;
position: relative;
float: left;
width: calc(100% - 18px);
overflow: hidden;
}
Expand Down
1 change: 1 addition & 0 deletions src/core/styles/components/_common/_igx-vhelper.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
%vhelper--vertical {
position: absolute;
width: 18px;
top: 0;
right: 0;
}

Expand Down
1 change: 1 addition & 0 deletions src/core/styles/components/checkbox/_checkbox-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
cursor: pointer;
width: $size;
height: $size;
min-width: $size;
border-width: $border-width;
border-style: solid;
border-color: map-get($this, 'empty-color');
Expand Down
31 changes: 2 additions & 29 deletions src/core/styles/components/grid/_grid-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -156,32 +156,6 @@
overflow: hidden;
}

%vhelper-display {
&::-webkit-scrollbar {
background: rgba(text-contrast(map-get($this, 'content-background')), .12);

/* stylelint-disable selector-pseudo-class-no-unknown */
&:vertical {
border-left: 1px solid rgba(text-contrast(map-get($this, 'content-background')), .08);
border-right: 1px solid rgba(text-contrast(map-get($this, 'content-background')), .08);
}

&:horizontal {
border-top: 1px solid rgba(text-contrast(map-get($this, 'content-background')), .08);
border-bottom: 1px solid rgba(text-contrast(map-get($this, 'content-background')), .08);
}
/* stylelint-enable */
}

&::-webkit-scrollbar-thumb {
background: rgba(text-contrast(map-get($this, 'content-background')), .24);

&:hover {
background: rgba(text-contrast(map-get($this, 'content-background')), .37);
}
}
}

%grid-caption {
display: flex;
align-items: center;
Expand Down Expand Up @@ -258,7 +232,6 @@
background: map-get($this, 'content-background');
color: map-get($this, 'content-text-color');
overflow: hidden;
will-change: transform;
}

%grid-tbody--empty {
Expand All @@ -272,11 +245,11 @@
flex-flow: row nowrap;
grid-row: 5;
width: 100%;
background: map-get($this, 'content-background');
background: map-get($this, 'header-background');
}

%grid-scroll-start {
border-right: map-get($cell-pin, 'style') map-get($cell-pin, 'color');
background: igx-color($palette, 'grays', 200);
}

%grid-scroll-main {
Expand Down
1 change: 1 addition & 0 deletions src/core/styles/components/radio/_radio-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
display: inline-block;
width: $size;
height: $size;
min-width: $size;
line-height: $size;
cursor: pointer;
color: map-get($this, 'label-color');
Expand Down
1 change: 1 addition & 0 deletions src/core/styles/components/switch/_switch-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@
display: block;
width: $switch-thumb-width;
height: $switch-thumb-height;
min-width: $switch-thumb-width;
border-radius: 50%;
background: map-get($this, 'thumb-off-color');
box-shadow: $switch-shadow;
Expand Down