Skip to content

feat(tabs): add full rtl support #10684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 6, 2022
Merged

feat(tabs): add full rtl support #10684

merged 13 commits into from
Jan 6, 2022

Conversation

viktorkombov
Copy link
Contributor

Closes #5904

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

DiyanDimitrov
DiyanDimitrov reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@DiyanDimitrov DiyanDimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have some minor suggestions.

@DiyanDimitrov DiyanDimitrov self-requested a review January 5, 2022 09:01
DiyanDimitrov
DiyanDimitrov previously approved these changes Jan 5, 2022
View reviewed changes
@teodosiah teodosiah added the ❌ status: awaiting-test PRs awaiting manual verification label Jan 5, 2022
@tishko0 tishko0 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 5, 2022
@tishko0 tishko0 added the ✅ status: verified Applies to PRs that have passed manual verification label Jan 6, 2022
@teodosiah teodosiah merged commit f753d1a into master Jan 6, 2022
@teodosiah teodosiah deleted the vkombov/feat-5904-master branch January 6, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

Assignees

@tishko0 tishko0

Labels
RTL Support tabs version: 13.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs component does not support RTL
4 participants
@viktorkombov @DiyanDimitrov @tishko0 @teodosiah