Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(themes): use spacing for margin and padding #11419

Closed
wants to merge 24 commits into from

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Apr 18, 2022

Closes #11368

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

simeonoff and others added 15 commits April 20, 2022 11:18
* feat(themes): use spacing for margin and paddings.
* refactor(date-range): use spacing vars

* refactor(date-picker): don't adjust label spacing

Co-authored-by: Dilyana Dimova <[email protected]>
Co-authored-by: Simeon Simeonoff <[email protected]>
* refactor(expansion-panel): use spacing

* Update projects/igniteui-angular/src/lib/core/styles/components/expansion-panel/_expansion-panel-theme.scss

Co-authored-by: Silvia Ivanova <[email protected]>
* refactor(input-group): use spacing for padding and margin

Co-authored-by: Silvia Ivanova <[email protected]>
* refactor(grid): use spacing for margin and padding

Co-authored-by: Marin Popov <[email protected]>
* refactor(components): use spacing for margin and padding
@simeonoff simeonoff changed the title refactor(badge, button): use spacing for margin and padding refactor(themes): use spacing for margin and padding May 9, 2022
@simeonoff simeonoff requested a review from desig9stein May 31, 2022 08:50
@simeonoff simeonoff requested a review from didimmova May 31, 2022 08:50
* refactor(bottom-nav): refactor spacing to make more sense

* refactor(navdrawer): fix right margin

* fix(stepper): fix spacing

* fix(slider): fix spacing

* fix(calendar): fix typography spacing for days headers
@simeonoff simeonoff marked this pull request as ready for review June 16, 2022 07:45
@github-actions
Copy link

There has been no recent activity and this PR has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 16, 2022
@simeonoff simeonoff removed the status: inactive Used to stale issues and pull requests label Aug 16, 2022
@simeonoff
Copy link
Collaborator Author

Closing as this will be refactored in 15.1.x following the update to igniteui-theming.

@simeonoff simeonoff closed this Sep 30, 2022
@ChronosSF ChronosSF deleted the simeonoff/css-spacing-vars branch June 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Themes: Add support for adjusting spacing via CSS vars
4 participants