Skip to content

refactor(components): use spacing for margin and padding #11444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simeonoff merged 10 commits into from
Apr 21, 2022
Merged

refactor(components): use spacing for margin and padding #11444

simeonoff merged 10 commits into from
Apr 21, 2022

Conversation

@desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Apr 20, 2022 •
edited
Loading

Closes #11368

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein requested a review from simeonoff April 20, 2022 07:21
@desig9stein desig9stein changed the title spacing vars refactor(components): use spacing for margin and padding Apr 20, 2022
@simeonoff simeonoff requested a review from SisIvanova April 20, 2022 12:53
@simeonoff simeonoff merged commit cca5b72 into simeonoff/css-spacing-vars Apr 21, 2022
@simeonoff simeonoff deleted the mpopov/css-spacing-vars branch April 21, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

@SisIvanova SisIvanova SisIvanova approved these changes

Assignees

No one assigned

Labels

action-strip banner Banner component button-group nav-drawer navbar paginator progress-bar ✨ themes version: 13.2.x ❌ status: awaiting-test PRs awaiting manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desig9stein @simeonoff @SisIvanova