Skip to content

feat(mask): Escape mask pattern literals #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 10, 2023
Merged

Conversation

rkaraivanov
Copy link
Member

Closes #7089

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

kdinev
kdinev previously approved these changes Feb 21, 2023
@kdinev
Copy link
Member

kdinev commented Feb 21, 2023

Hmmm, this started failing in the regular Chrome run also, but just for the date format:

1) should properly build input formats based on locale
     DateTimeUtil Unit tests
     Expected 'dd.MM.yyyy г.' to equal 'dd.MM.yyyy г.'.

jackofdiamond5
jackofdiamond5 previously approved these changes Mar 9, 2023
@jackofdiamond5 jackofdiamond5 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Mar 9, 2023
@ChronosSF ChronosSF merged commit fba2569 into master Mar 10, 2023
@ChronosSF ChronosSF deleted the rkaraivanov/issue-7089 branch March 10, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mask-editor version: 15.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

igxMask always set the symbol '9' as a fillable spot
4 participants