Skip to content

fix(combo): Handle selection when placed in an IgxGrid cell template and grid is virtualized - 18.0.x #14413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2024
Merged

fix(combo): Handle selection when placed in an IgxGrid cell template and grid is virtualized - 18.0.x #14413

merged 6 commits into from
Jun 28, 2024

Conversation

ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Jun 19, 2024 •
edited
Loading

Closes #14305

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddaribo ddaribo force-pushed the bpachilova/comboIdChangeInTemplate-fix-14305-18.0.x branch from 80447dc to 0394ade Compare June 19, 2024 10:05
@ddaribo ddaribo added the ❌ status: awaiting-test PRs awaiting manual verification label Jun 19, 2024
@ddaribo ddaribo requested a review from jackofdiamond5 June 19, 2024 10:39
jackofdiamond5
jackofdiamond5 previously approved these changes Jun 20, 2024
View reviewed changes
@ddaribo ddaribo linked an issue Jun 20, 2024 that may be closed by this pull request
When change in first row of dropdown then 13 th row dropdown changes automatically #14305
Closed
@ddaribo ddaribo requested a review from jackofdiamond5 June 27, 2024 08:01
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 27, 2024
@kacheshmarova kacheshmarova merged commit dd7bdfa into 18.0.x Jun 28, 2024
4 checks passed
@kacheshmarova kacheshmarova deleted the bpachilova/comboIdChangeInTemplate-fix-14305-18.0.x branch June 28, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

Assignees

@RivaIvanova RivaIvanova

Labels
combo grid simple-combo version: 18.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When change in first row of dropdown then 13 th row dropdown changes automatically
4 participants
@ddaribo @jackofdiamond5 @kacheshmarova @RivaIvanova