Skip to content

feat(grid): expose editorOptions for the default editors and improve built-in editing for date/time cols (input formats) #14465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 77 commits into from
Oct 11, 2024
Merged

feat(grid): expose editorOptions for the default editors and improve built-in editing for date/time cols (input formats) #14465

merged 77 commits into from
Oct 11, 2024

Conversation

ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Jul 3, 2024 •
edited
Loading

Related to #14009 and #14010

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them - compare revisions
    TODO: refactor the column datat types spec after comments, update editors spec

@ddaribo ddaribo requested review from ChronosSF and rkaraivanov July 3, 2024 08:37
ddaribo and others added 10 commits July 12, 2024 15:42
@ddaribo ddaribo changed the title feat(date-time-util): logic to identify numeric formats for editing feat(grid): expose editorOptions for the default editors and improve built-in editing for date/time cols (input formats) Jul 15, 2024
@ddaribo ddaribo added the grid label Jul 15, 2024
@ddaribo ddaribo force-pushed the bpachilova/grid-editor-options-feat-14009 branch from e8ca056 to 4c0b4fa Compare July 17, 2024 14:37
@ddaribo ddaribo force-pushed the bpachilova/grid-editor-options-feat-14009 branch 2 times, most recently from 8268f79 to b06fe16 Compare July 19, 2024 07:20
@ddaribo ddaribo requested a review from damyanpetev October 7, 2024 12:55
@ChronosSF ChronosSF self-assigned this Oct 9, 2024
@ChronosSF ChronosSF added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 9, 2024
@ddaribo ddaribo force-pushed the bpachilova/grid-editor-options-feat-14009 branch from f118f04 to 4a213bc Compare October 9, 2024 16:38
@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 11, 2024
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 11, 2024
@ChronosSF ChronosSF merged commit 7774f3d into master Oct 11, 2024
5 checks passed
@ChronosSF ChronosSF deleted the bpachilova/grid-editor-options-feat-14009 branch October 11, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

@jackofdiamond5 jackofdiamond5 Awaiting requested review from jackofdiamond5

@gedinakova gedinakova Awaiting requested review from gedinakova

@ChronosSF ChronosSF Awaiting requested review from ChronosSF

@onlyexeption onlyexeption Awaiting requested review from onlyexeption

Assignees

@ChronosSF ChronosSF

Labels
date-time-utils grid squash-merge Merge PR with "Squash and Merge" option triage: blocking version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ddaribo @ChronosSF @jackofdiamond5 @damyanpetev @onlyexeption