Skip to content

Themes: Indigo Updates for Calendar, Grid, Combo, and Select #14607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 61 commits into from
Sep 20, 2024
Merged

Themes: Indigo Updates for Calendar, Grid, Combo, and Select #14607

merged 61 commits into from
Sep 20, 2024

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Jul 31, 2024 •
edited
Loading

Closes #14407

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff changed the base branch from master to 18.1.x July 31, 2024 13:21
@simeonoff simeonoff marked this pull request as ready for review August 2, 2024 08:19
@simeonoff simeonoff requested a review from desig9stein August 2, 2024 08:19
This was linked to issues Aug 2, 2024
Indigo: Update select theme IgniteUI/igniteui-theming#301
Closed
Indigo: Update combo theme IgniteUI/igniteui-theming#302
Closed
Indigo Theme Calendar Improvements IgniteUI/igniteui-webcomponents#1263
Closed
Indigo Theme Calendar Improvements #14407
Closed
Indigo: Grid Updates IgniteUI/igniteui-theming#279
Closed
@sdimchevski sdimchevski assigned yradoeva and unassigned sbayreva Aug 8, 2024
@AnjiManova

This comment was marked as outdated.

Sign in to view
@yradoeva

This comment was marked as outdated.

Sign in to view
@yradoeva

This comment was marked as resolved.

Sign in to view
@imincheva

This comment was marked as resolved.

Sign in to view
@yradoeva

This comment was marked as resolved.

Sign in to view
simeonoff
simeonoff commented Sep 19, 2024
View reviewed changes
Copy link
Collaborator Author

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a few instances of hardcoded colors based on the theme variant (light/dark). Can we have them in the schema declarations?

@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 20, 2024
@simeonoff simeonoff merged commit b0a9482 into master Sep 20, 2024
5 checks passed
@simeonoff simeonoff deleted the simeonoff/indigo-themes branch September 20, 2024 13:47
@simeonoff simeonoff restored the simeonoff/indigo-themes branch September 26, 2024 11:08
@simeonoff simeonoff deleted the simeonoff/indigo-themes branch September 26, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SisIvanova SisIvanova SisIvanova approved these changes

@desig9stein desig9stein Awaiting requested review from desig9stein

Assignees

@andiesm813 andiesm813

@imincheva imincheva

@yradoeva yradoeva

Labels
design: verified indigo-theme ✨ themes version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
9 participants
@simeonoff @AnjiManova @yradoeva @andiesm813 @imincheva @sdimchevski @desig9stein @SisIvanova @sbayreva