Skip to content

feat(carousel): align with WC carousel #14651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Sep 26, 2024
Merged

feat(carousel): align with WC carousel #14651

merged 54 commits into from
Sep 26, 2024

Conversation

RivaIvanova
Copy link
Member

@RivaIvanova RivaIvanova commented Aug 20, 2024 •
edited
Loading

Closes #14627

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@RivaIvanova RivaIvanova added the ❌ status: awaiting-test PRs awaiting manual verification label Aug 26, 2024
@RivaIvanova RivaIvanova marked this pull request as ready for review August 26, 2024 08:45
@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 4, 2024
@RivaIvanova RivaIvanova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 4, 2024
@RivaIvanova RivaIvanova added the ❌ status: awaiting-test PRs awaiting manual verification label Sep 19, 2024
simeonoff
simeonoff previously approved these changes Sep 24, 2024
View reviewed changes
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 24, 2024
rkaraivanov
rkaraivanov requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tiny issue in the changelog.

@rkaraivanov rkaraivanov merged commit 4009f4d into master Sep 26, 2024
5 checks passed
@rkaraivanov rkaraivanov deleted the rivanova/feat-carousel-14627 branch September 26, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@SisIvanova SisIvanova

@imincheva imincheva

@yradoeva yradoeva

Labels
🎠 carousel design: verified version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
8 participants
@RivaIvanova @yradoeva @simeonoff @rkaraivanov @sdimchevski @SisIvanova @imincheva @sbayreva