Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple-combo): allow values to be selected on tab press - master #14708

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

georgianastasov
Copy link
Contributor

Closes #14085

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

jackofdiamond5
jackofdiamond5 previously approved these changes Sep 4, 2024
@RivaIvanova RivaIvanova self-assigned this Sep 9, 2024
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 9, 2024
@RivaIvanova
Copy link
Member

public data: any[] = [
    { id: 1, name: 'Apple' },
    { id: 2, name: 'Orange' },
    { id: 3, name: 'Mango' },
];
<igx-simple-combo
  [data]="data"
  [valueKey]="'id'"
  [displayKey]="'name'"
  [allowCustomValues]="true"
>
</igx-simple-combo>

Entering a value that does not exist in the data and pressing Tab throws an error.
igx-simple-combo-tab

@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Sep 9, 2024
@georgianastasov georgianastasov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 9, 2024
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 9, 2024
@Lipata Lipata merged commit 04e214c into master Sep 10, 2024
5 of 6 checks passed
@Lipata Lipata deleted the ganastasov/feat-14085-master branch September 10, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgxSimpleCombo: Combo gets cleared when entering a valid value and press tab
4 participants