feat(IgxState): Re-use matching columns for state. #14756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note to self: For scenarios where you have moved a child column inside a group column, sort keys so that they still match. |
dkamburov
added
💥 status: in-test
damyanpetev
previously approved these changes
Oct 21, 2024
Member
damyanpetev
left a comment
damyanpetev
left a comment
There was a problem hiding this comment.
Thinking this is a neat enhancement, could do with with being documented in the changelog. Otherwise, LGTM.
dkamburov
previously approved these changes
Oct 21, 2024
Contributor
|
@MayaKirova I couldn't merge it, can you please resolve the conflict? |
damyanpetev
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13659
Closes #14896
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)