Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grid-summary): summary disabling with disabledSummaries property #15006

Merged
merged 7 commits into from
Nov 12, 2024
Merged

feat(grid-summary): summary disabling with disabledSummaries property #15006

merged 7 commits into from
Nov 12, 2024

Conversation

georgianastasov
Copy link
Contributor

Closes #14905

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddincheva
Copy link
Contributor

When some of the summaries are disabled the height of the summary row is not recalculated:
SummaryHeight

@Zneeky Zneeky added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 12, 2024
@kacheshmarova kacheshmarova merged commit 3ac7898 into master Nov 12, 2024
5 checks passed
@kacheshmarova kacheshmarova deleted the ganastasov/feat-14905-master branch November 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddincheva ddincheva ddincheva approved these changes

Assignees

@Zneeky Zneeky

Labels
grid: summaries grid version: 19.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify hiding Grid summary results through API
6 participants
@georgianastasov @ddincheva @kacheshmarova @Zneeky @hanastasov @zdrawku