Skip to content

feat(button-group): improve button group theme #15501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

didimmova
Copy link
Contributor

Closes #15491

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@didimmova didimmova requested a review from simeonoff March 11, 2025 15:54
@didimmova didimmova linked an issue Mar 11, 2025 that may be closed by this pull request
@SisIvanova
Copy link
Collaborator

There are some differences between this branch and the master branch/WC components. For example, check the selected + focused background color, or the focused box-shadow z-index
Screenshot 2025-04-16 at 2 07 42 PM
Screenshot 2025-04-16 at 2 08 13 PM

@SisIvanova SisIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 16, 2025
@didimmova
Copy link
Contributor Author

There are some differences between this branch and the master branch/WC components. For example, check the selected + focused background color, or the focused box-shadow z-index Screenshot 2025-04-16 at 2 07 42 PM Screenshot 2025-04-16 at 2 08 13 PM

Does this have to do anything to do with this task?

@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 17, 2025
@simeonoff simeonoff merged commit 0048844 into didimmova/improve-component-themes Apr 25, 2025
@simeonoff simeonoff deleted the didimmova/improve-button-group-theme branch April 25, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
button-group ✨ themes ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Button Group Theme
3 participants