Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stepper): scope styles to component #15503

Open
wants to merge 5 commits into
base: simeonoff/scoped-styles
Choose a base branch
from

Conversation

desig9stein
Copy link
Contributor

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@adrianptrv
Copy link

adrianptrv commented Mar 13, 2025

I found that some parameters from the stepper theming function don't work.

  • $current-subtitle-color, $title-hover-color, $subtitle-hover-color, $current-step-focus-background and $invalid-step-focus-background - do not work when applied with the theming function, only their vars get declacred.

Out of these 5 parameters, only - $title-hover-color and $subtitle-hover-color do not work on the master branch either, for which I will raise a separate issue.


  • $invalid-step-background and $current-step-background parameters also do not work as expected, they paint both the step and the step separator next to it with the set color."
    Screenshot 2025-03-13 at 15 00 27
    The issue is only seen here, on the master branch, they work fine:
    Screenshot 2025-03-13 at 15 01 22

It seems that the colors from these parameters are applied to the igx-step element, which contains the div for the step and the ::before pseudo-element that represents the step separator, which is also colored. On the master branch, the colors are applied only to the div that holds the step.
Screenshot 2025-03-13 at 15 08 53

@adrianptrv
Copy link

adrianptrv commented Mar 14, 2025

I also found some discrepancies between some themes styles and their UI Kits.

On the dark version of the Fluent theme - the completed version of the step has a dark gray background, while in the UI kit, it has a light gray background.
UI Kit:
Screenshot 2025-03-14 at 13 55 05

Current:
fluent_completed


On the dark version of the Bootstrap theme - again the completed version of the step have a gray background and black icon/text color, while in the UI kit is with white icon/text color.
UI Kit:
Screenshot 2025-03-14 at 13 56 48

Current:
bootstrap_completed


On the dark version of the Material theme - the normal state of the step, when the stepper is not linear, has a gray background with black icon/text color, while in the UI kit, it has white icon/text color.
Ui Kit:
Screenshot 2025-03-14 at 15 27 20

Current:
material_default


On all themes and versions, the progress bar (step separator) in vertical view doesn't get colored, while the one in horizontal view is colored.
Screenshot 2025-03-14 at 13 36 01

@desig9stein
Copy link
Contributor Author

desig9stein commented Mar 14, 2025

@adrianptrv All comments, except the first and last, are a result of testing with an incorrect local schema. For instance, if your global theme is set to Fluent, but your local theme schema defaults to Material (default), inconsistencies will arise.

When creating a custom theme, ensure the schema matches the global theme—even if the global theme is Material Dark, the local schema will default to Material Light unless explicitly specified. Failing to do so can lead to various issues.

All other issues from the comments are fixed and can be tested

@simeonoff simeonoff linked an issue Mar 19, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stepper]: Bundle theme styles to component
2 participants