Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): updating node versions in workflows #15541

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [20.x, 22.x]

steps:
- name: Checkout
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
cache: 'npm'
registry-url: 'https://registry.npmjs.org'
- run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
2,027 changes: 1,097 additions & 930 deletions package-lock.json

Large diffs are not rendered by default.

50 changes: 25 additions & 25 deletions package.json
Original file line number Diff line number Diff line change
@@ -58,17 +58,17 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^19.1.6",
"@angular/common": "^19.1.6",
"@angular/compiler": "^19.1.6",
"@angular/core": "^19.1.6",
"@angular/elements": "^19.1.6",
"@angular/forms": "^19.1.6",
"@angular/platform-browser": "^19.1.6",
"@angular/platform-browser-dynamic": "^19.1.6",
"@angular/platform-server": "^19.1.6",
"@angular/router": "^19.1.6",
"@angular/ssr": "^19.1.7",
"@angular/animations": "^19.2.2",
"@angular/common": "^19.2.2",
"@angular/compiler": "^19.2.2",
"@angular/core": "^19.2.2",
"@angular/elements": "^19.2.2",
"@angular/forms": "^19.2.2",
"@angular/platform-browser": "^19.2.2",
"@angular/platform-browser-dynamic": "^19.2.2",
"@angular/platform-server": "^19.2.2",
"@angular/router": "^19.2.2",
"@angular/ssr": "^19.2.3",
"@igniteui/material-icons-extended": "^3.1.0",
"@lit-labs/ssr-dom-shim": "^1.2.1",
"@types/source-map": "0.5.2",
@@ -77,21 +77,21 @@
"igniteui-theming": "^17.0.0",
"igniteui-trial-watermark": "^3.0.2",
"lodash-es": "^4.17.21",
"rxjs": "^7.8.0",
"rxjs": "^7.8.2",
"tslib": "^2.3.0",
"zone.js": "~0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^19.1.7",
"@angular-devkit/schematics": "^19.1.7",
"@angular-eslint/builder": "^19.1.0",
"@angular-eslint/eslint-plugin": "^19.1.0",
"@angular-eslint/eslint-plugin-template": "^19.1.0",
"@angular-eslint/schematics": "^19.1.0",
"@angular-eslint/template-parser": "^19.1.0",
"@angular/cli": "^19.1.7",
"@angular/compiler-cli": "^19.1.6",
"@angular/language-service": "^19.1.6",
"@angular-devkit/build-angular": "^19.2.3",
"@angular-devkit/schematics": "^19.2.3",
"@angular-eslint/builder": "^19.2.1",
"@angular-eslint/eslint-plugin": "^19.2.1",
"@angular-eslint/eslint-plugin-template": "^19.2.1",
"@angular-eslint/schematics": "^19.2.1",
"@angular-eslint/template-parser": "^19.2.1",
"@angular/cli": "^19.2.3",
"@angular/compiler-cli": "^19.2.2",
"@angular/language-service": "^19.2.2",
"@angularclass/hmr": "^3.0.0",
"@microsoft/signalr": "^7.0.12",
"@types/estree": "^1.0.0",
@@ -118,7 +118,7 @@
"hammer-simulator": "0.0.1",
"hammerjs": "^2.0.8",
"ig-typedoc-theme": "^6.0.0",
"igniteui-dockmanager": "^1.16.0",
"igniteui-dockmanager": "^1.16.1",
"igniteui-sassdoc-theme": "^1.2.3",
"igniteui-webcomponents": "5.2.0",
"jasmine": "^5.6.0",
@@ -131,11 +131,11 @@
"karma-parallel": "^0.3.1",
"karma-spec-reporter": "^0.0.36",
"lit-html": "^3.2.1",
"ng-packagr": "^19.1.2",
"ng-packagr": "^19.2.0",
"postcss": "^8.5.1",
"postcss-scss": "^4.0.6",
"prettier": "^3.3.3",
"puppeteer": "^24.2.1",
"puppeteer": "^24.4.0",
"sass-embedded": "^1.83.4",
"sass-true": "^8.1.0",
"sassdoc": "^2.7.4",
10 changes: 5 additions & 5 deletions projects/igniteui-angular/src/lib/grids/grid-base.directive.ts
Original file line number Diff line number Diff line change
@@ -260,7 +260,7 @@ export abstract class IgxGridBaseDirective implements GridType,
* ```
*/
@Input()
public emptyGridTemplate: TemplateRef<void>;
public emptyGridTemplate: TemplateRef<IgxGridTemplateContext>;

/**
* Gets/Sets a custom template for adding row UI when grid is empty.
@@ -282,7 +282,7 @@ export abstract class IgxGridBaseDirective implements GridType,
* ```
*/
@Input()
public loadingGridTemplate: TemplateRef<void>;
public loadingGridTemplate: TemplateRef<IgxGridTemplateContext>;

/**
* Get/Set IgxSummaryRow height
@@ -3765,7 +3765,7 @@ export abstract class IgxGridBaseDirective implements GridType,
this._setupListeners();
this.rowListDiffer = this.differs.find([]).create(null);
// compare based on field, not on object ref.
this.columnListDiffer = this.differs.find([]).create((index, col: ColumnType) => col.field);
this.columnListDiffer = this.differs.find([]).create((_index, col: ColumnType) => col.field);
this.calcWidth = this.width && this.width.indexOf('%') === -1 ? parseInt(this.width, 10) : 0;
this.gridComputedStyles = this.document.defaultView.getComputedStyle(this.nativeElement);
}
@@ -6091,7 +6091,7 @@ export abstract class IgxGridBaseDirective implements GridType,
/**
* @hidden @internal
*/
public trackColumnChanges(index, col) {
public trackColumnChanges(_index, col) {
return col.field + col._calcWidth;
}

@@ -7615,7 +7615,7 @@ export abstract class IgxGridBaseDirective implements GridType,
}
// find next/prev record that is editable.
const nextRowIndex = previous ? this.findPrevEditableDataRowIndex(currentRowIndex) :
this.dataView.findIndex((rec, index) =>
this.dataView.findIndex((_rec, index) =>
index > resolvedIndex && this.isEditableDataRecordAtIndex(index));
const nextDataIndex = this.getDataIndex(nextRowIndex);
return nextDataIndex !== -1 ? nextDataIndex : currentRowIndex;

Unchanged files with check annotations Beta

this.colsWidth = event.target.value;
}
public onColEnter(event: IDropBaseEventArgs, rowIndex, colIndex) {

Check warning on line 170 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x)

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 170 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x)

'event' is defined but never used. Allowed unused args must match /^_/u
this.collection[rowIndex][colIndex].hovered = true;
}
public onColLeave(event: IDropBaseEventArgs, rowIndex, colIndex) {

Check warning on line 174 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x)

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 174 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x)

'event' is defined but never used. Allowed unused args must match /^_/u
this.collection[rowIndex][colIndex].hovered = false;
}
this.resizeVisible = true;
}
public onBlur(event, rowIndex, colIndex) {

Check warning on line 235 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x)

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 235 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x)

'event' is defined but never used. Allowed unused args must match /^_/u
this.cellSelected = null;
this.collection[rowIndex][colIndex].selected = false;
this.resizeVisible = false;
event.target.setPointerCapture(event.pointerId);
}
public pointerMoveResizeLeft(event, cellRef, rowIndex, colIndex) {

Check warning on line 250 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x)

'rowIndex' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 250 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x)

'rowIndex' is defined but never used. Allowed unused args must match /^_/u
if (this.dragStarted) {
const curDistance = this.dragStartX - event.pageX;
const minIncrease = -this.curResizedCell.colSpan;
}
}
public pointerMoveResizeRight(event, cellRef, rowIndex, colIndex) {

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x)

'rowIndex' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x)

'cellRef' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x)

'rowIndex' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x)

'cellRef' is defined but never used. Allowed unused args must match /^_/u
if (this.dragStarted) {
const curDistance = event.pageX - this.dragStartX;
const maxIncrease = this.colsCount - (colIndex + this.curResizedCell.colSpan);
return `${this.remoteService.url}?$count=true&$skip=${state.startIndex}&$top=${chunkSize}`;
};
// eslint-disable-next-line prefer-spread
this.localItems = Array.apply(null, { length: 2000 }).map((e, i) => ({

Check warning on line 41 in src/app/drop-down/drop-down-virtual/drop-down-virtual.component.ts

GitHub Actions / run-tests (20.x)

'e' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 41 in src/app/drop-down/drop-down-virtual/drop-down-virtual.component.ts

GitHub Actions / run-tests (22.x)

'e' is defined but never used. Allowed unused args must match /^_/u
name: `Item ${i + 1}`,
id: i
}));
public toggleStartPageY;
// Multi selection row drag
public sourceRows: any[] = Array.from(Array(10)).map((e, i) => {

Check warning on line 103 in src/app/drag-drop/drag-drop.sample.ts

GitHub Actions / run-tests (20.x)

'e' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 103 in src/app/drag-drop/drag-drop.sample.ts

GitHub Actions / run-tests (22.x)

'e' is defined but never used. Allowed unused args must match /^_/u
return {name: "Item " + i, selected: false}
});
public targetRows: any[] = [];
item.dragged = false;
}
public listItemEnter(event, itemIndex) {

Check warning on line 333 in src/app/drag-drop/drag-drop.sample.ts

GitHub Actions / run-tests (20.x)

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 333 in src/app/drag-drop/drag-drop.sample.ts

GitHub Actions / run-tests (22.x)

'event' is defined but never used. Allowed unused args must match /^_/u
const moveDown = this.draggedIndex < itemIndex;
const listNotesDirsArray = this.listNotesDirs.toArray();
}
}
public listItemOver(event, itemIndex) {

Check warning on line 394 in src/app/drag-drop/drag-drop.sample.ts

GitHub Actions / run-tests (20.x)

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 394 in src/app/drag-drop/drag-drop.sample.ts

GitHub Actions / run-tests (22.x)

'event' is defined but never used. Allowed unused args must match /^_/u
const moveDown = itemIndex > this.draggedIndex;
const itemDragDir = this.listNotesDirs.toArray()[itemIndex];