Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grids): correct column position after unpinning when there are hidden columns - 18.2.x #15546

Open
wants to merge 3 commits into
base: 18.2.x
Choose a base branch
from
Open

fix(grids): correct column position after unpinning when there are hidden columns - 18.2.x #15546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ff1ee
chore(col-pinning-tests): remove duplicated test
ddaribo Mar 19, 2025
e70d660
test(column-pinning): order of columns after unpinning w/ hidden cols
ddaribo Mar 19, 2025
da6898c
fix(column): account for hidden cols with _unpinnedColumns for indice…
ddaribo Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/igniteui-angular/src/lib/grids/columns/column.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2217,7 +2217,7 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy
// estimate the exact index at which column will be inserted
// takes into account initial unpinned index of the column
if (!hasIndex) {
const indices = grid.unpinnedColumns.map(col => col.index);
const indices = grid._unpinnedColumns.map(col => col.index);
indices.push(this.index);
indices.sort((a, b) => a - b);
index = indices.indexOf(this.index);
Expand Down
51 changes: 30 additions & 21 deletions projects/igniteui-angular/src/lib/grids/grid/column-pinning.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,27 +111,6 @@ describe('Column Pinning UI #grid', () => {
verifyColumnIsPinned(column, false, 0);
});

it('Checks order of columns after unpinning', () => {
for (const column of grid.columnList) {
column.pin();
}
fix.detectChanges();
grid.getColumnByName('ID').unpin();
grid.getColumnByName('ReleaseDate').unpin();
grid.getColumnByName('Downloads').unpin();
grid.getColumnByName('ProductName').unpin();
grid.getColumnByName('Released').unpin();
fix.detectChanges();
grid.unpinnedColumns.forEach((column, index) => {
if (index === grid.unpinnedColumns.length - 1) {
return;
}
expect(
column.index < grid.unpinnedColumns[index + 1].index
).toBe(true);
});
});

it('reflects properly grid column pinned value changes.', () => {
const name = 'ReleaseDate';
verifyCheckbox(name, false, false, columnChooserElement);
Expand Down Expand Up @@ -310,6 +289,36 @@ describe('Column Pinning UI #grid', () => {
).toBe(true);
});
});

it('Checks order of columns after unpinning if there are hidden columns', () => {
// Columns are ordered like this: ID, ProductName, Downloads, Released, ReleaseDate
expect(grid.getColumnByName('Downloads').index).toBe(2);
expect(grid.getColumnByName('Released').index).toBe(3);

grid.getColumnByName('ID').hidden = true;
grid.getColumnByName('Downloads').pin();
grid.getColumnByName('Released').pin();
fix.detectChanges();

// unpinnedColumns contains only visible cols
expect(grid.unpinnedColumns.length).toBe(2);
// _unpinnedColumns contains all unpinned cols (including hidden)
expect((grid as any)._unpinnedColumns.length).toBe(3);

grid.getColumnByName('Released').unpin();
fix.detectChanges();

expect(grid.unpinnedColumns.length).toBe(3);
expect((grid as any)._unpinnedColumns.length).toBe(4);
// Downloads is still pinned; ID is not part of unpinnedColumns
expect(grid.getColumnByName('Released').field).toEqual((grid as any).unpinnedColumns[1].field);
expect(grid.getColumnByName('Released').field).toEqual((grid as any)._unpinnedColumns[2].field);

grid.getColumnByName('Downloads').unpin();
fix.detectChanges();
expect(grid.getColumnByName('Downloads').field).toEqual((grid as any).unpinnedColumns[1].field);
expect(grid.getColumnByName('Downloads').field).toEqual((grid as any)._unpinnedColumns[2].field);
});
});

describe('Pinning with Column Groups', () => {
Expand Down
Loading