fix(drp): getEditElement() return type as base definition #16439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddaribo
added
❌ status: awaiting-test
Copilot finished reviewing on behalf of
ddaribo
November 11, 2025 12:37
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the return type of the getEditElement() method in the date range picker component to match the base class definition. The change removes optional typing by ensuring the method always returns a non-null HTMLInputElement.
- Changed
getEditElement()return type fromHTMLInputElement | undefinedtoHTMLInputElement - Updated implementation to use non-null assertion operator on
inputDirective
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16437
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)